From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mario Kleiner Subject: Re: [PATCH 05/19] drm: Have the vblank counter account for the time between vblank irq disable and drm_vblank_off() Date: Tue, 02 Sep 2014 21:33:18 +0200 Message-ID: <54061B7E.40202@gmail.com> References: <1407325803-6944-1-git-send-email-ville.syrjala@linux.intel.com> <1407325803-6944-6-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1407325803-6944-6-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com, dri-devel@lists.freedesktop.org Cc: Daniel Vetter , intel-gfx List-Id: dri-devel@lists.freedesktop.org SGkgVmlsbGUsCgp3ZW50IHRocm91Z2ggdGhlIHZibGFuayByZXdvcmsgcGF0Y2ggc2V0LCBtb3N0 bHkgbG9va3MgZ29vZCB0byBtZS4gSSAKY291bGRuJ3QgZmluZCBhbnkgYnVncyBpbiB0aGUgY29k ZS4gQSBmaXJzdCBxdWljayB0ZXN0LXJ1biBvbiBteSBvbGQgCkludGVsIEdNQS05NTAgKEdlbiAz J2lzaCBpIHRoaW5rPykgYWxzbyBkaWRuJ3Qgc2hvdyBhcHBhcmVudCBwcm9ibGVtcyAKd2l0aCB0 aGUgT01MX3N5bmNfY29udHJvbCBmdW5jdGlvbnMuIEknbGwgdHJ5IHRvIHRlc3QgbW9yZSBjYXJl ZnVsbHkgCndpdGggdGhhdCBjYXJkIGFuZCBtYXliZSB3aXRoIGEgZmV3IG1vcmUgY2FyZHMgaW4g dGhlIG5leHQgZGF5cywgaWYgaSAKY2FuIGdldCBteSBoYW5kcyBvbiBzb21ldGhpbmcgbW9yZSBy ZWNlbnQuCgpUaGUgcHJvYmxlbWF0aWMgYml0czoKClBhdGNoIDMvMTkgW0Rvbid0IGNsZWFyIHZi bGFuayB0aW1lc3RhbXAuLi5dIGluIGNvbWJpbmF0aW9uIHdpdGggWzUvMTkgCmJlbG93XToKCkkg YWdyZWUgdGhhdCBub3QgY2xlYXJpbmcgdGhlIHRpbWVzdGFtcHMgZHVyaW5nIGRybV92Ymxhbmtf b2ZmKCkgaXMgCnByb2JhYmx5IHRoZSBiZXR0ZXIgdGhpbmcgdG8gZG8gZm9yIHVzZXJzcGFjZS4g VGhlIGlkZWEgYmVoaW5kIGNsZWFyaW5nIAp0aGUgdGltZXN0YW1wcyB3YXMgdGhhdCBhIHVzdCB0 aW1lc3RhbXAgb2YgemVybyBzaWduYWxzIHRvIHVzZXJzcGFjZSAKdGhhdCB0aGUgdGltZXN0YW1w IGlzIGludmFsaWQvdW5kZWZpbmVkIGF0IHRoZSBtb21lbnQsIHNvIHRoZSBjbGllbnQgCnNob3Vs ZCByZXRyeSB0aGUgcXVlcnkgaWYgaXQgbmVlZHMgYSB2YWxpZCB0aW1lc3RhbXAuIFRoaXMgd29y a2VkIGluIApwcmFjdGljZSBpbnNvZmFyIGFzIGEgdmFsdWUgb2YgemVybyBjYW4ndCBoYXBwZW4g bm9ybWFsbHksIHVubGVzcyBhIApjbGllbnQgd291bGQgcXVlcnkgYSB0aW1lc3RhbXAgZHVyaW5n IHRoZSBmaXJzdCBtaWNyb3NlY29uZCBzaW5jZSAKbWFjaGluZSBwb3dlcnVwLiBCdXQgaSBndWVz cyByZXR1cm5pbmcgdGhlIGxhc3QgdmFsaWQgKG1zYywgdXN0KSBwYWlyIHRvIAphIGNsaWVudCBk dXJpbmcgdmJsYW5rIG9mZiBtYXkgYmUgYmV0dGVyIGZvciB0aGluZ3MgbGlrZSBjb21wb3NpdG9y cyAKZXRjLiBJIGFsc28gd29uZGVyIGlmIHdlIGV2ZXIgZG9jdW1lbnRlZCB0aGlzIHVzdCA9PSAw IC0+IC1FQUdBSU4gYmVoYXZpb3VyPwoKVGhlIHByb2JsZW0gd2l0aCBwYXRjaCA1LzE5IGlzIGdw dXMvZHJpdmVycyB3aGljaCBkb24ndCBwcm92aWRlIHByZWNpc2UgCmluc3RhbnRhbmVvdXMgdmJs YW5rIHRpbWVzdGFtcHMgLSB3aGljaCBhcmUgYWZhaWsgZXZlcnl0aGluZyBleGNlcHQgCmludGVs LCByYWRlb24gYW5kIG5vdXZlYXUuIE9uIHN1Y2ggZHJpdmVycywgdGhlIG9sZCBjb2RlIHdvdWxk IHJldHVybiBhIAp6ZXJvIHVzdCB0aW1lc3RhbXAgZHVyaW5nIHF1ZXJpZXMgYWZ0ZXIgdGhlIGZp cnN0IGRybV92YmxhbmtfZ2V0KCkgYW5kIAp1bnRpbCB0aGUgZmlyc3QgdmJsYW5rIGlycSBoYXBw ZW5zIGFuZCBpbml0aWFsaXplcyB0aGUgdGltZXN0YW1wcyB0byAKc29tZXRoaW5nIHZhbGlkLiBU aGUgemVybyB1c3Qgd291bGQgc2lnbmFsICJwbGVhc2UgcmV0cnkiIHRvIHRoZSBjbGllbnQuIApX aXRoIHBhdGNoIDUvMTkgeW91J2QgZ2V0IGFuIHVwZGF0ZWQgdmJsYW5rIGNvdW50ZXIgd2l0aCBh biBvdXRkYXRlZCAKdmJsYW5rIHRpbWVzdGFtcCAtIHdoYXRldmVyIGlzIHN0b3JlZCBpbiB0aGUg cmluZ2J1ZmZlciBmcm9tIHRoZSBwYXN0LCAKYmVjYXVzZSBkcm1fdXBkYXRlX3ZibGFua19jb3Vu dCgpIGNhbid0IHVwZGF0ZSB0aGUgdGltZXN0YW1wIHdpdGhvdXQgCnN1cHBvcnQgZm9yIHRoZSBv cHRpb25hbCB2YmxhbmstdGltZXN0YW1wIGRyaXZlciBmdW5jdGlvbi4gQSBtaXNtYXRjaGVkIApt c2MsIHVzdCB3b3VsZCBiZSB2ZXJ5IGNvbmZ1c2luZyB0byBjbGllbnRzLgoKVGhlIG9ubHkgd2F5 IG9uZSBjb3VsZCBnZXQgdmFsaWQgbXNjICsgdXN0IG9uIHN1Y2ggZHJpdmVycyB3b3VsZCBiZSB0 byAKZW5hYmxlIHZibGFuayBpcnEncyBhbmQgdGhlbiB3YWl0IGZvciB0aGUgbmV4dCB2Ymxhbmsg aXJxIHRvIGFjdHVhbGx5IAp1cGRhdGUgdGhlIHRpbWVzdGFtcCwgYXQgdGhlIGNvc3Qgb2YgYSBj b3VwbGUgb2YgbXNlY3Mgd2FpdGluZyB0aW1lLgoKU28gZWl0aGVyIGhhdmUgZHJtX3VwZGF0ZV92 YmxhbmtfY291bnQoKSBpdHNlbGYgc2xlZXAgdW50aWwgbmV4dCB2YmxhbmsgCiJpZiAoIXJjKSAu Li4iIGF0IHRoZSB2ZXJ5IGVuZCwgYXMgYSByYyA9PSAwIHdvdWxkIHNpZ25hbCBhbiAKaW1wcmVj aXNlL3dyb25nIHZibGFuayB0aW1lc3RhbXAuIE9yIGhhdmUgYWxsIGNhbGxlcnMgb2YgaXQgZG8g dGhpcywgaWYgCmxvY2tpbmcgbWFrZXMgaXQgbmVjY2Vzc2FyeS4gT3Igb25seSBjYXJlIGFib3V0 IGl0IGZvciB0aGUgCmRybV92Ymxhbmtfb2ZmKCkgc3BlY2lhbCBjYXNlLCBlLmcuLCBpZiAhdmJs YW5rLT5lbmFibGVkIHRoZXJlLCB0aGVuIApkcm1fdmJsYW5rX2dldCgpIC0+IHdhaXQgZm9yIGEg dmFsaWQgdGltZXN0YW1wIGFuZCBjb3VudCB0byBzaG93IHVwIC0+IApkcm1fdmJsYW5rX3B1dCgp IC0+IHZibGFua19kaXNhYmxlX2FuZF9zYXZlKCkuCgoKRm9yIFBhdGNoIDExLzE5IFtBZGQgZGV2 LT52YmxhbmtfZGlzYWJsZV9pbW1lZGlhdGUgZmxhZ106IENhbiB3ZSBtYWtlIGl0IApzbyB0aGF0 IGEgZHJtX3ZibGFua19vZmZkZWxheSBtb2R1bGUgcGFyYW1ldGVyIG9mIHplcm8gYWx3YXlzIG92 ZXJyaWRlcyAKdGhlIGZsYWc/IFRoZSBvbmx5IHJlYXNvbiB3aHkgYSB1c2VyIHdhbnRzIHRvIHNl dCBkcm1fdmJsYW5rX29mZmRlbGF5IHRvIAp6ZXJvIGlzIGlmIHRoYXQgdXNlciBhYnNvbHV0ZWx5 IG5lZWRzIHByZWNpc2UgYW5kIHJlbGlhYmxlIHZibGFuayAKY291bnRzL3RpbWVzdGFtcHMgYW5k IGZpbmRzIG91dCB0aGF0IHNvbWV0aGluZyBpcyBicm9rZW4gd2l0aCBoaXMgCmRyaXZlcitncHUs IHNvIHVzZXMgdGhpcyBhcyBhbiBvdmVycmlkZSB0byB0ZW1wb3JhcmlseSBmaXggYSBicm9rZW4g CmRyaXZlci4gVGhhdCBkb2Vzbid0IHdvcmsgaWYgdGhlIHZibGFua19kaXNhYmxlX2ltbWVkaWF0 ZSBmbGFnIG92ZXJyaWRlcyAKdGhlIG92ZXJyaWRlIGZyb20gdGhlIHVzZXIgLSB0aGUgdXNlciBj b3VsZG4ndCBvcHQgb3V0IG9mIHRoZSB0cm91YmxlLgoKVGhpcyBtaWdodCBub3QgYmUgc3VjaCBh biBpc3N1ZSB3aXRoIEludGVsIGNhcmRzLCBhcyB5b3UgaGF2ZSB0ZXN0IApzdWl0ZXMgYW5kIGEg UUEgdGVhbSwgYW5kIGkgYXNzdW1lL2hvcGUgeW91IHRlc3RlZCBldmVyeSBzaW5nbGUgaW50ZWwg CmdwdSBzaGlwcGVkIGluIHRoZSBsYXN0IGRlY2FkZSBvciBzbyBpZiB0aGUgd2hvbGUgdmJsYW5r IG9mZi9vbiBsb2dpYyAKcmVhbGx5IGlzIHBlcmZlY3RseSByYWNlLWZyZWUgbm93PyBBdCBsZWFz dCBpdCBzZWVtcyB0byB3b3JrIHdpdGggdGhhdCAKb25lIGdlbi0zIGNhcmQgaSBxdWlja2x5IHRl c3RlZC4gQnV0IGZvciBtb3N0IG90aGVyIGRyaXZlcnMgd2l0aCBzbWFsbCAKdGVhbXMgYW5kIG5v IGRlZGljYXRlZCBRQSB0aGlzIGNvdWxkIGVuZCBiYWRseSBxdWlja2x5IGZvciB0aGUgdXNlciAK d2l0aG91dCBhbnkgbWFudWFsIG92ZXJyaWRlLgoKVGhlIGRvY3Mgc2hvdWxkIHByb2JhYmx5IGNs YXJpZnkgdGhhdCBhIGh3IHZibGFuayBjb3VudGVyIGlzbid0IGVub3VnaCAKZm9yIHRoZSB2Ymxh bmtfZGlzYWJsZV9pbW1lZGlhdGUgZmxhZyB0byBiZSBzZXQuIFRoZWlyIHZibGFuayAKb2ZmL29u L2hhcmR3YXJlIGNvdW50ZXIgcXVlcnkgaW1wbGVtZW50YXRpb24gbXVzdCBiZSBjb21wbGV0ZWx5 IHJhY2UgCmZyZWUuIGlpcmMgdGhpcyBtZWFucyB0aGUgaHcgY291bnRlciBxdWVyeSBtdXN0IGJl aGF2ZSBhcyBpZiB0aGUgdmJsYW5rIApjb3VudGVyIGFsd2F5cyBpbmNyZW1lbnRzIGF0IHRoZSBs ZWFkaW5nIGVkZ2Ugb2YgdmJsYW5rLiBFLmcuLCByYWRlb24gCmhhcyBodyBjb3VudGVyIHF1ZXJp ZXMsIGJ1dCB0aGUgY291bnRlciBpbmNyZW1lbnRzIGVpdGhlciBhdCB0aGUgCnRyYWlsaW5nIGVk Z2UsIG9yIHNvbWV3aGVyZSBpbiB0aGUgbWlkZGxlIG9mIHZibGFuaywgc28gdGhlcmUgaXQgCndv dWxkbid0IHdvcmsgd2l0aG91dCByYWNlcywgY2F1c2luZyBvZmYtYnktb25lIGVycm9ycyBzb21l dGltZXMuCgpGb3IgUGF0Y2ggMTQvMTkgW0Rvbid0IHVwZGF0ZSB2YmxhbmsgdGltZXN0YW1wIHdo ZW4gdGhlIGNvdW50ZXIgZGlkbid0IApjaGFuZ2VdCgpUaGF0IHdvdWxkIGdvIHdyb25nIGlmIGEg ZHJpdmVyIGRvZXNuJ3QgaW1wbGVtZW50IGEgcHJvcGVyIHZibGFuayAKY291bnRlciBxdWVyeS4g RS5nLiwgbm91dmVhdSBoYXMgcHJlY2lzZSB2YmxhbmsgdGltZXN0YW1waW5nIHNpbmNlIExpbnV4 IAozLjE0LCBidXQgc3RpbGwgbm8gZnVuY3Rpb25hbCBodyBjb3VudGVyIHF1ZXJ5LgoKQWxtb3N0 IGFsbCBlbWJlZGRlZCBncHUgZHJpdmVycyBjdXJyZW50bHkgaW1wbGVtZW50IGNvbXBsZXRlbHkg Ym9ndXMgaHcgCnZibGFuayBjb3VudGVyIHF1ZXJpZXMsIGJlY2F1c2UgdGhhdCBkcml2ZXIgaG9v ayBpcyBtYW5kYXRvcnkuIEkgdGhpbmsgCml0IHdvdWxkIG1ha2Ugc2Vuc2UgaWYgd2Ugd291bGQg bWFrZSB0aGF0IGhvb2sgb3B0aW9uYWwsIGFsbG93IGEgTlVMTCAKZnVuY3Rpb24gcG9pbnRlciBh bmQgYWRhcHQgdG8gdGhlIGxhY2sgb2YgdGhhdCBxdWVyeSwgZS5nLiwgYnkgbmV2ZXIgCmRpc2Fi bGluZyB2YmxhbmsgaXJxJ3MsIGV4Y2VwdCBpbiBkcm1fdmJsYW5rX29mZigpIHdoZW4gYSBrbXMt ZHJpdmVyIAppbnNpc3RzIG9uIGRpc2FibGluZyBpdHMgaXJxIGR1cmluZyBtb2Rlc2V0L2RwbXMg b2ZmL3N1c3BlbmQgZXRjLgoKV2l0aCB0aGVzZSByZW1hcmtzIHNvbWVob3cgdGFrZW4gaW50byBh Y2NvdW50IHlvdSBoYXZlIG15CgpSZXZpZXdlZC1ieTogTWFyaW8gS2xlaW5lciA8bWFyaW8ua2xl aW5lci5kZUBnbWFpbC5jb20+Cgpmb3IgdGhlIHdob2xlIHNlcmllcywgaWYgeW91IHdhbnQuCgp0 aGFua3MsCi1tYXJpbwoKT24gMDgvMDYvMjAxNCAwMTo0OSBQTSwgdmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxh QGxpbnV4LmludGVsLmNvbT4KPgo+IElmIHRoZSB2YmxhbmsgaXJxIGhhcyBhbHJlYWR5IGJlZW4g ZGlzYWJsZWQgKHZpYSB0aGUgZGlzYWJsZSB0aW1lcikgd2hlbgo+IHdlIGNhbGwgZHJtX3ZibGFu a19vZmYoKSBzYW1wbGUgdGhlIGNvdW50ZXIgYW5kIHRpbWVzdGFtcCBvbmUgbGFzdCB0aW1lLgo+ IFRoaXMgd2lsbCBtYWtlIHRoZSBzdXJlIHRoYXQgdGhlIHVzZXIgc3BhY2UgdmlzaWJsZSBjb3Vu dGVyIHdpbGwgYWNjb3VudAo+IGZvciB0aW1lIGJldHdlZW4gdmJsYW5rIGlycSBkaXNhYmxlIGFu ZCBkcm1fdmJsYW5rX29mZigpLgo+Cj4gUmV2aWV3ZWQtYnk6IE1hdHQgUm9wZXIgPG1hdHRoZXcu ZC5yb3BlckBpbnRlbC5jb20+Cj4gUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52 ZXR0ZXJAZmZ3bGwuY2g+Cj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9kcm1faXJx LmMgfCAxMyArKysrKysrKysrKysrCj4gICAxIGZpbGUgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygr KQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1faXJxLmMgYi9kcml2ZXJzL2dw dS9kcm0vZHJtX2lycS5jCj4gaW5kZXggYWY5NjUxNy4uMWY4NmY2YyAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2lycS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9pcnEu Ywo+IEBAIC0xNDAsNiArMTQwLDE5IEBAIHN0YXRpYyB2b2lkIHZibGFua19kaXNhYmxlX2FuZF9z YXZlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGludCBjcnRjKQo+ICAgCSAqLwo+ICAgCXNwaW5f bG9ja19pcnFzYXZlKCZkZXYtPnZibGFua190aW1lX2xvY2ssIGlycWZsYWdzKTsKPiAgIAo+ICsJ LyoKPiArCSAqIElmIHRoZSB2YmxhbmsgaW50ZXJydXB0IHdhcyBhbHJlYWR5IGRpc2JsZWQgdXBk YXRlIHRoZSBjb3VudAo+ICsJICogYW5kIHRpbWVzdGFtcCB0byBtYWludGFpbiB0aGUgYXBwZWFy YW5jZSB0aGF0IHRoZSBjb3VudGVyCj4gKwkgKiBoYXMgYmVlbiB0aWNraW5nIGFsbCBhbG9uZyB1 bnRpbCB0aGlzIHRpbWUuIFRoaXMgbWFrZXMgdGhlCj4gKwkgKiBjb3VudCBhY2NvdW50IGZvciB0 aGUgZW50aXJlIHRpbWUgYmV0d2VlbiBkcm1fdmJsYW5rX29uKCkgYW5kCj4gKwkgKiBkcm1fdmJs YW5rX29mZigpLgo+ICsJICovCj4gKwlpZiAoIWRldi0+dmJsYW5rW2NydGNdLmVuYWJsZWQpIHsK PiArCQlkcm1fdXBkYXRlX3ZibGFua19jb3VudChkZXYsIGNydGMpOwo+ICsJCXNwaW5fdW5sb2Nr X2lycXJlc3RvcmUoJmRldi0+dmJsYW5rX3RpbWVfbG9jaywgaXJxZmxhZ3MpOwo+ICsJCXJldHVy bjsKPiArCX0KPiArCj4gICAJZGV2LT5kcml2ZXItPmRpc2FibGVfdmJsYW5rKGRldiwgY3J0Yyk7 Cj4gICAJZGV2LT52YmxhbmtbY3J0Y10uZW5hYmxlZCA9IGZhbHNlOwo+ICAgCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=