From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Velikov Subject: Re: [PATCH] drm/vmwgfx: Fix drm.h include Date: Mon, 08 Sep 2014 13:42:21 +0100 Message-ID: <540DA42D.3080208@gmail.com> References: <20140905171959.GO5216@hansolo.jdub.homelinux.org> <540D9A9B.6070706@gmail.com> <540D9DC5.8010101@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 4A3BF6E0F9 for ; Mon, 8 Sep 2014 05:43:26 -0700 (PDT) Received: by mail-wg0-f49.google.com with SMTP id m15so1412571wgh.8 for ; Mon, 08 Sep 2014 05:43:25 -0700 (PDT) In-Reply-To: <540D9DC5.8010101@vmware.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas Hellstrom Cc: dmarlin@redhat.com, Josh Boyer , emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Brian Paul List-Id: dri-devel@lists.freedesktop.org On 08/09/14 13:15, Thomas Hellstrom wrote: > Hi! > > On 09/08/2014 02:01 PM, Emil Velikov wrote: [snip] >> >> To the VMware guys, >> >> Any objections if we update the libdrm header and drop the mesa/ddx copies ? >> >> Cheers, >> Emil > Hi! > > vmwgfx libdrm is pretty obsolete and AFAIK not used by anyone. > As such, it's unnecessary to release a new version of libdrm each time > the vmwgfx header is updated, and I'd like to avoid that dependency. > Better to keep the local copies in the gallium winsys and the DDX. Since > the ioctl interface is backwards compatible, it doesn't really matter if > the headers are slightly out of sync. > Afaict libdrm releases are dirt cheap, and should not cause any issues. Yet it's your code so you'll be the judge of it all. I'm just a de-duplication fanatic :) -Emil