dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <deathsimple@vodafone.de>
To: Sergey Korshunoff <seyko2@gmail.com>, dri-devel@lists.freedesktop.org
Subject: Re: PATCH: radeondrm x86_64 and android32
Date: Mon, 15 Sep 2014 13:54:05 +0200	[thread overview]
Message-ID: <5416D35D.4080109@vodafone.de> (raw)
In-Reply-To: <CAKG6wnYmYnWjTFqvwX=06b503JjXtVPTdxhKimV8b0q7+GLTjQ@mail.gmail.com>

Am 15.09.2014 um 12:09 schrieb Sergey Korshunoff:
> Android-x86 4.0-r1 (32 bit) have problems with x86_64 kernel when he
> trying to use a radeon kms. The following change correct a problem:
>
> drivers/gpu/drm/radeon_kms.c (function radeon_info_ioctl):
>
> - value_ptr = (uint32_t *)((unsigned long)info->value);
> + value_ptr = (uint32_t *)((unsigned)info->value);
>
> Looks like a userspace data in android running under x86_64 is located
> above 4 Gb. I don't think so. But after this change android run fine.

That's most likely a bug on the userspace side, caused by the upper 
32bits of info->value not initialized properly.

The kernel patch you show above will most likely just break 64bit userspace.

Regards,
Christian.

> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2014-09-15 11:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-15 10:09 PATCH: radeondrm x86_64 and android32 Sergey Korshunoff
2014-09-15 11:54 ` Christian König [this message]
2014-09-15 15:43   ` Sergey Korshunoff
2014-09-15 16:07     ` Christian König
2014-09-16 13:29       ` Sergey Korshunoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5416D35D.4080109@vodafone.de \
    --to=deathsimple@vodafone.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=seyko2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox