From: "Michel Dänzer" <michel@daenzer.net>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 4/4] drm/mm: Remove DRM_MM_SEARCH_BEST
Date: Tue, 04 Nov 2014 17:47:22 +0900 [thread overview]
Message-ID: <5458929A.7030203@daenzer.net> (raw)
In-Reply-To: <CADnq5_PH=u8K2LvEFUY2OCGvwtYEgEezoS1ep0AfSemA-OwA9A@mail.gmail.com>
On 01.11.2014 03:10, Alex Deucher wrote:
> On Thu, Oct 30, 2014 at 4:36 AM, Michel Dänzer <michel@daenzer.net> wrote:
>> From: Michel Dänzer <michel.daenzer@amd.com>
>>
>> In the words of Daniel Vetter:
>>
>> «I think SEARCH_BEST is pretty much always a bad idea - it rips apart
>> allocations from the same execbuf, and usually those get recycled around
>> the same time. Which means you'll just fragment your mm even more if you
>> try to find the best hole instead of just picking one and the stuffing
>> the entire execbuf into it. So imo we might as well just kill it.»
>>
>> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
>
> Applied this series to my -next tree.
Thanks. Unfortunately, the removal of DRM_MM_SEARCH_BEST caused
performance regressions, presumably due to excessive eviction from VRAM,
see https://bugs.freedesktop.org/show_bug.cgi?id=84662#c49 . I can
reproduce a significant bad effect with the UE4 Elemental demo on my
development machine. Please drop this patch.
The original patches 4 & 5 have the same effect, so they shouldn't be
applied either. Maybe we can try this again once TTM is using the MM
scan roaster for eviction.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-11-04 8:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 9:35 [PATCH 1/5] drm/radeon: Set TTM_PL_FLAG_TOPDOWN also for RADEON_GEM_CPU_ACCESS BOs Michel Dänzer
2014-10-28 9:35 ` [PATCH 2/5] drm/ttm: Add DRM_MM_SEARCH_BELOW for TTM_PL_FLAG_TOPDOWN Michel Dänzer
2014-10-28 9:35 ` [PATCH 3/5] drm/ttm: Use only " Michel Dänzer
2014-10-28 11:10 ` Daniel Vetter
2014-10-30 8:41 ` Michel Dänzer
2014-10-30 15:07 ` Thomas Hellstrom
2014-10-31 17:19 ` Daniel Vetter
2014-10-28 9:35 ` [PATCH 4/5] drm/ttm: Add TTM_PL_FLAG_BOTTOMUP Michel Dänzer
2014-10-30 8:36 ` [PATCH 4/4] drm/mm: Remove DRM_MM_SEARCH_BEST Michel Dänzer
2014-10-31 18:10 ` Alex Deucher
2014-11-04 8:47 ` Michel Dänzer [this message]
2014-11-04 14:30 ` Alex Deucher
2014-10-28 9:35 ` [PATCH 5/5] drm/radeon: Use TTM_PL_FLAG_BOTTOMUP Michel Dänzer
2014-10-28 10:46 ` [PATCH 1/5] drm/radeon: Set TTM_PL_FLAG_TOPDOWN also for RADEON_GEM_CPU_ACCESS BOs Lauri Kasanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5458929A.7030203@daenzer.net \
--to=michel@daenzer.net \
--cc=alexdeucher@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox