From: nick <xerofoify@gmail.com>
To: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Arthur Borsboom <arthurborsboom@gmail.com>,
Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH] drivers:gpu:drm Remove unneeded struct of type psb_intel_i2c_chan in the header file psb_drv.h
Date: Sun, 30 Nov 2014 14:12:55 -0500 [thread overview]
Message-ID: <547B6C37.1040709@gmail.com> (raw)
In-Reply-To: <CAMeQTsaOOMmw1ECZ+KZN8iyGB3ePFjAU_H55E2LRooexKOnijg@mail.gmail.com>
Sorry about that Patrik. I will resend a v2 with just the FIXME removed.
Regards Nick
On 2014-11-30 08:02 AM, Patrik Jakobsson wrote:
> On Sun, Nov 30, 2014 at 3:24 AM, Nicholas Krause <xerofoify@gmail.com> wrote:
>> Removes unneeeded struct *lvds_i2c_bus of type, psb_intel_i2c_chan as this struct
>> is no needed due to never being used in the header file, psb_drv.h and therefore
>> should be removed from this header file.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>
> The lvds_i2c_bus is in use and can't be removed. Please at least compile test
> your patches before submitting them.
>
> Cheers
> Patrik
>
>> ---
>> drivers/gpu/drm/gma500/psb_drv.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h
>> index 55ebe2b..fc74518 100644
>> --- a/drivers/gpu/drm/gma500/psb_drv.h
>> +++ b/drivers/gpu/drm/gma500/psb_drv.h
>> @@ -522,7 +522,6 @@ struct drm_psb_private {
>> struct drm_display_mode *sdvo_lvds_vbt_mode;
>>
>> struct bdb_lvds_backlight *lvds_bl; /* LVDS backlight info from VBT */
>> - struct psb_intel_i2c_chan *lvds_i2c_bus; /* FIXME: Remove this? */
>>
>> /* Feature bits from the VBIOS */
>> unsigned int int_tv_support:1;
>> --
>> 2.1.0
>>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2014-11-30 19:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-30 2:24 [PATCH] drivers:gpu:drm Remove unneeded struct of type psb_intel_i2c_chan in the header file psb_drv.h Nicholas Krause
2014-11-30 13:02 ` Patrik Jakobsson
2014-11-30 19:12 ` nick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547B6C37.1040709@gmail.com \
--to=xerofoify@gmail.com \
--cc=airlied@redhat.com \
--cc=arthurborsboom@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).