dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Vikas Patil <vikasmpatil@gmail.com>,
	Rob Clark <robdclark@gmail.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: omapdrm/pvr kernel crash with camera capture and display application
Date: Tue, 2 Dec 2014 15:15:27 +0200	[thread overview]
Message-ID: <547DBB6F.6030503@ti.com> (raw)
In-Reply-To: <CA+kt3u3D7PPLUcBi+1Y-Doho0eTExVNA2xrCx+OkhVsGEPo0hA@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 981 bytes --]

Hi,

On 02/12/14 14:41, Vikas Patil wrote:
> Hi All,
> 
> What I found is UnwrapExtMemoryCallBack() function from
> eurasia_km\services4\srvkm\common\devicemem.c always calls
> omap_gem_put_pages(), however just before the crash  it calls
> omap_gem_put_paddr() and it crashes in it due to  NULL pointer
> dereference of  &obj->dev->struct_mutex. instead of
> omap_gem_put_pages(). Does this gives any clue on what might be going
> wrong? What OMAP_BO_TILED_MASK signifies?

OMAP_BO_TILED_MASK tells that the buffer has been allocated with TILER.

I'm not really familiar with this stuff, but I presume a matching
operation is done in PVRSRVImportGEMKM().

But but... If &obj->dev->struct_mutex causes a NULL ref, it sounds to me
that the memory has already been released, or somehow else a NULL has
gotten into there.

Even if the code would accidentally call omap_gem_put_paddr instead of
omap_gem_put_pages, the struct_mutex should be fine.

 Tomi



[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2014-12-02 13:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01 14:08 omapdrm/pvr kernel crash with camera capture and display application Vikas Patil
2014-12-02 12:41 ` Vikas Patil
2014-12-02 13:15   ` Tomi Valkeinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547DBB6F.6030503@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=robdclark@gmail.com \
    --cc=vikasmpatil@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox