From: Oded Gabbay <oded.gabbay@amd.com>
To: "Christian König" <deathsimple@vodafone.de>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/4] amdkfd: fix error printing in kfd_ioctl()
Date: Sun, 14 Dec 2014 16:20:48 +0200 [thread overview]
Message-ID: <548D9CC0.2060906@amd.com> (raw)
In-Reply-To: <548D9A49.80203@vodafone.de>
On 12/14/2014 04:10 PM, Christian König wrote:
> Am 14.12.2014 um 14:35 schrieb Oded Gabbay:
>> When an ioctl function returns -EAGAIN, don't print error in kfd_ioctl()
>
> You most likely want to handle -ERESTARTSYS the same way.
>
> Christian.
Thanks, will fix and resend.
Oded
>
>>
>> Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
>> ---
>> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
>> b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
>> index 7d4974b..69c5fe7 100644
>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
>> @@ -571,7 +571,7 @@ static long kfd_ioctl(struct file *filep, unsigned int
>> cmd, unsigned long arg)
>> break;
>> }
>> - if (err < 0)
>> + if ((err < 0) && (err != -EAGAIN))
>> dev_err(kfd_device,
>> "ioctl error %ld for ioctl cmd 0x%x (#%d)\n",
>> err, cmd, _IOC_NR(cmd));
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-12-14 14:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-14 13:35 [PATCH 1/4] amdkfd: fix error printing in kfd_ioctl() Oded Gabbay
2014-12-14 13:35 ` [PATCH 2/4] amdkfd: Add number of watch points to topology Oded Gabbay
2014-12-14 13:35 ` [PATCH 3/4] amdkfd: Remove duplicate include Oded Gabbay
2014-12-14 13:35 ` [PATCH 4/4] amdkfd: Process-device data creation and lookup split Oded Gabbay
2014-12-14 14:10 ` [PATCH 1/4] amdkfd: fix error printing in kfd_ioctl() Christian König
2014-12-14 14:20 ` Oded Gabbay [this message]
2014-12-15 7:59 ` Daniel Vetter
2014-12-15 8:32 ` Dave Airlie
2014-12-15 13:48 ` Oded Gabbay
2014-12-29 12:44 ` Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548D9CC0.2060906@amd.com \
--to=oded.gabbay@amd.com \
--cc=deathsimple@vodafone.de \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox