From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonas Lundqvist Subject: Re: [PATCH] drm: Move two seq_printf's outside of locked mutex Date: Wed, 31 Dec 2014 09:55:19 +0100 Message-ID: <54A3B9F7.4080808@gannon.se> References: <1419976466-2113-1-git-send-email-jonas@gannon.se> <20141230225211.GB31616@hudson.localdomain> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tXjPh5Uqja7uCCBHKVu4xtldnvNUnAHVT" Return-path: In-Reply-To: <20141230225211.GB31616@hudson.localdomain> Sender: linux-kernel-owner@vger.kernel.org To: Jeremiah Mahler , airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tXjPh5Uqja7uCCBHKVu4xtldnvNUnAHVT Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi Jeremiah, On 12/30/2014 11:52 PM, Jeremiah Mahler wrote: > You changed 'i' but you didn't explain in your log message why you did = this. I can change the commit message to something more generic. "Move code outside of locked mutex" or similar. > Does this change really improve anything? It may work the same with th= e > locks moved around. But if you look at the function as a whole, the > locks encapsulate the body of this function nicely. I like the origina= l > design better. The locking was already done this way, ie after the seq_printf, in the functions drm_clients_info() and drm_gem_name_info() in thr same file. So this change is really more of an alignment. Best regards Jonas --tXjPh5Uqja7uCCBHKVu4xtldnvNUnAHVT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUo7n7AAoJEBKd4UpXCeED+DsP/3H7VzYXnfEFB5y5uvmPU0rN BJQbd/xFhRHsFe2pN6dTRtsryV6N3mA4ce+yGnQ2eFjUgE20xRS3hjWnsPmRRF1K i5btlEs6PkH/3c09ShxUNLIJZSxFLmRcfFtTDTo3t82+AV7AY7Ti5BrCYpL5vfJh GDYnvYqAGzekEqrpGImDMBSe2MlL4As1I0F+EKunxgcs05aKkdn8kPUWis2urQw2 KipKMaG3o0/WIZ2YJY1VhnHibKJ4TEPtZHBMKmlnoD4IdZKFLTNAkLltCg6OagkQ Q43GwA1BQNOz9tGfs3SMfOUToP6nDNxB4RHGWqys5LA9z7PGEIs0npn7HxY0Amk+ hh3ETWPZffGcXRGZnbtfLRkmYgouE7EmZk6gmOcrnO8YS5xXsWPRUvo8B/SjryqT pL6T9z4zhr+RuscEg6TxwVTpaCQtEmPe8pNtDlU0zqSfNlEL/qT9Ic7UqZQgt1gl dh8ZPywOS3LnAcfgpegW1w8VmQD21Wk20ecWiOWSSNHcxiamkCyDT9GND1UuAVKg iqMTBSNEu/o8Xdp+WYqX4rSSQgCQQen3OpUaJMVtbyCC8ycj3zZxfDM60rOdAVOH /QCzP90/LFavHT8euhE/oLu/WDCVrNBW+9sAkjcBXooeCERzmrH68ocXBEb542gX VOAYTDIceLKlSdynqvq5 =h2Db -----END PGP SIGNATURE----- --tXjPh5Uqja7uCCBHKVu4xtldnvNUnAHVT--