From: Ian Romanick <idr-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org>
To: Chris Wilson
<chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>,
xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
mesa-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [Mesa-dev] [mesa 9/9] glx/dri2: Implement getBufferAge
Date: Tue, 20 Jan 2015 12:49:48 -0800 [thread overview]
Message-ID: <54BEBF6C.7080103@freedesktop.org> (raw)
In-Reply-To: <54BEBBF9.8010104-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org>
On 01/20/2015 12:35 PM, Ian Romanick wrote:
> On 01/19/2015 03:00 AM, Chris Wilson wrote:
>> + DRI2Buffer *buffers;
>> +
>> + for (i = 0; i < priv->bufferCount; i++)
>> + attachments[i] = priv->buffers[i].attachment;
>> +
>> + buffers = DRI2GetBuffers(priv->base.psc->dpy, priv->base.xDrawable,
>> + &priv->width, &priv->height,
>> + attachments, i, &i);
>
> Most drivers prefer DRI2GetBuffersWithFormat, and some drivers only use
> DRI2GetBuffersWithFormat. Is mixing DRI2GetBuffersWithFormat and
> DRI2GetBuffers going to cause problems or unexpected behavior changes?
Okay... I hadn't seen the server change until after I sent this review.
I sent some comments there.
This should be fine, but can we get a comment that it relies on
DRI2GetBuffers re-using the format from the previous
DRI2GetBuffersWithFormat? That way the next person to look at the code
won't make the same mistake I made.
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
next prev parent reply other threads:[~2015-01-20 20:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 11:00 Implement GLX_EXT_buffer_age for DRI2 Chris Wilson
[not found] ` <1421665245-5994-1-git-send-email-chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>
2015-01-19 11:00 ` [dri2proto] Declare DRI2ParamXHasBufferAge Chris Wilson
[not found] ` <1421665245-5994-2-git-send-email-chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>
2015-01-20 20:53 ` [Mesa-dev] " Ian Romanick
2015-06-16 12:25 ` Martin Peres
2015-01-19 11:00 ` [xorg 1/3] dri2: Allow GetBuffers to match any format Chris Wilson
2015-01-20 20:49 ` [Mesa-dev] " Ian Romanick
2015-06-16 13:11 ` Martin Peres
2015-01-19 11:00 ` [xorg 2/3] dri2: Pass swap-interval=0 ScheduleSwap requests to the ddx Chris Wilson
2015-02-18 19:57 ` Fredrik Höglund
2015-01-19 11:00 ` [xorg 3/3] dri2: Reuse unused flags in GetBuffers protocol to pass last SBC Chris Wilson
2015-01-19 14:14 ` Chris Wilson
2015-01-19 14:29 ` [PATCH v2] " Chris Wilson
2015-01-20 21:55 ` Ian Romanick
2015-01-19 11:00 ` [xf86-video-ati] dri2: Enable BufferAge support Chris Wilson
2015-01-20 16:47 ` Alex Deucher
2015-01-19 11:00 ` [xf86-video-nouveau] " Chris Wilson
[not found] ` <1421665245-5994-7-git-send-email-chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>
2015-05-09 4:41 ` Mario Kleiner
2015-01-19 11:00 ` [mesa 7/9] glx/dri2: Add DRI2GetParam() Chris Wilson
[not found] ` <1421665245-5994-8-git-send-email-chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>
2015-01-20 19:11 ` [Mesa-dev] " Ian Romanick
2015-01-19 11:00 ` [mesa 8/9] glx/dri2: Move the wait after SwapBuffers into the next GetBuffers Chris Wilson
2015-01-20 20:03 ` Ian Romanick
2015-01-19 11:00 ` [mesa 9/9] glx/dri2: Implement getBufferAge Chris Wilson
2015-01-20 20:35 ` Ian Romanick
[not found] ` <54BEBBF9.8010104-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org>
2015-01-20 20:49 ` Ian Romanick [this message]
2015-01-20 21:49 ` Implement GLX_EXT_buffer_age for DRI2 Dave Airlie
2015-02-18 18:40 ` [Mesa-dev] " Daniel Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BEBF6C.7080103@freedesktop.org \
--to=idr-cc+yj3umiyqdupfqwhejaq@public.gmane.org \
--cc=chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=mesa-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox