From: Thomas Hellstrom <thomas@shipmail.org>
To: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/vmwgfx: Replace the hw mutex with a hw spinlock
Date: Wed, 21 Jan 2015 07:18:13 +0100 [thread overview]
Message-ID: <54BF44A5.3070200@shipmail.org> (raw)
In-Reply-To: <CAPM=9tyjySmyQY+-2JUOBxj7HB6J7H2NUWbnfyrvrw_i4=7pWg@mail.gmail.com>
Hi, Dave,
It's intended for -fixes. I was just about to send a pull request but
got distracted.
Thanks,
Thomas
On 01/21/2015 12:45 AM, Dave Airlie wrote:
> On 19 January 2015 at 21:03, Thomas Hellstrom <thellstrom@vmware.com> wrote:
>> Fixes a case where we call vmw_fifo_idle() from within a wait function with
>> task state !TASK_RUNNING, which is illegal.
>>
>> In addition, make the locking fine-grained, so that it is performed once
>> for every read- and write operation. This is of course more costly, but we
>> don't perform much register access in the timing critical paths anyway. Instead
>> we have the extra benefit of being sure that we don't forget the hw lock around
>> register accesses. I think currently the kms code was quite buggy w r t this.
> So what is your feeling on this for -fixes?
>
> Dave.
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-01-21 6:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 11:03 [PATCH] drm/vmwgfx: Replace the hw mutex with a hw spinlock Thomas Hellstrom
2015-01-20 23:45 ` Dave Airlie
2015-01-21 6:18 ` Thomas Hellstrom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BF44A5.3070200@shipmail.org \
--to=thomas@shipmail.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox