From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jochen Rollwagen Subject: Bug in uninorth-agp.c parsing of module parameter uninorth_agp.aperture Date: Sun, 15 Feb 2015 19:27:48 +0100 Message-ID: <54E0E524.5070003@t-online.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1992974092==" Return-path: Received: from mailout11.t-online.de (mailout11.t-online.de [194.25.134.85]) by gabe.freedesktop.org (Postfix) with ESMTP id EF9CA6E10C for ; Sun, 15 Feb 2015 10:33:36 -0800 (PST) Received: from fwd20.aul.t-online.de (fwd20.aul.t-online.de [172.20.26.140]) by mailout11.t-online.de (Postfix) with SMTP id F3BE024F1DA for ; Sun, 15 Feb 2015 19:27:59 +0100 (CET) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --===============1992974092== Content-Type: multipart/alternative; boundary="------------080205030002000700070207" This is a multi-part message in MIME format. --------------080205030002000700070207 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi, i found a bug in uninorth-agp.c, function uninorth_fetch_size. the line size =memparse (aperture , &aperture ) >> 20; always sets size to zero which makes the driver allocate the default size of 256 MB which is obviously too large for older uninorth revisions. I split the line into memparse and shifting and inserted diagnostic messages, output with uninorth_agp.aperture = 32 as boot parameter: Feb 15 19:12:44 mac-mini kernel: [ 2.568636] agpgart-uninorth 0000:00:0b.0: size in uninorth_fetch_size after memparse: 32 Feb 15 19:12:44 mac-mini kernel: [ 2.568642] agpgart-uninorth 0000:00:0b.0: size after >> 20: 0 It would be nice if a patch could be produced so i can experiment with different aperture sizes without having to rebuild the kernel every time :-) Cheers Jochen --------------080205030002000700070207 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit Hi,

i found a bug in uninorth-agp.c, function uninorth_fetch_size.

the line

size = memparse(aperture, &aperture) >> 20;

always sets size to zero which makes the driver allocate the default size of 256 MB which is obviously too large for older uninorth revisions. 

I split the line into memparse and shifting and inserted diagnostic messages, output with uninorth_agp.aperture = 32 as boot parameter:

Feb 15 19:12:44 mac-mini kernel: [    2.568636] agpgart-uninorth 0000:00:0b.0: size in uninorth_fetch_size after memparse: 32
Feb 15 19:12:44 mac-mini kernel: [    2.568642] agpgart-uninorth 0000:00:0b.0: size after >> 20: 0

It would be nice if a patch could be produced so i can experiment with different aperture sizes without having to rebuild the kernel every time :-)

Cheers

Jochen
--------------080205030002000700070207-- --===============1992974092== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1992974092==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?TWljaGVsIETDpG56ZXI=?= Subject: Re: Bug in uninorth-agp.c parsing of module parameter uninorth_agp.aperture Date: Mon, 16 Feb 2015 11:51:05 +0900 Message-ID: <54E15B19.9050105@daenzer.net> References: <54E0E524.5070003@t-online.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 83A836E0A4 for ; Sun, 15 Feb 2015 18:51:09 -0800 (PST) In-Reply-To: <54E0E524.5070003@t-online.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jochen Rollwagen Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gMTYuMDIuMjAxNSAwMzoyNywgSm9jaGVuIFJvbGx3YWdlbiB3cm90ZToKPiBIaSwKPiAKPiBp IGZvdW5kIGEgYnVnIGluIHVuaW5vcnRoLWFncC5jLCBmdW5jdGlvbiB1bmlub3J0aF9mZXRjaF9z aXplLgo+IAo+IHRoZSBsaW5lCj4gCj4gc2l6ZSA9IG1lbXBhcnNlKGFwZXJ0dXJlLCAmYXBlcnR1 cmUpID4+IDIwOwo+IAo+IGFsd2F5cyBzZXRzIHNpemUgdG8gemVybyB3aGljaCBtYWtlcyB0aGUg ZHJpdmVyIGFsbG9jYXRlIHRoZSBkZWZhdWx0Cj4gc2l6ZSBvZiAyNTYgTUIgd2hpY2ggaXMgb2J2 aW91c2x5IHRvbyBsYXJnZSBmb3Igb2xkZXIgdW5pbm9ydGgKPiByZXZpc2lvbnMuCgpTb3VuZHMg bGlrZSB0aGUgZGVmYXVsdCBzaG91bGQgYmUgbG93ZXIgZm9yIG9sZGVyIFVuaU5vcnRoIHJldmlz aW9ucy4KQ2FuIHlvdSBtYWtlIGEgcGF0Y2ggZm9yIHRoYXQ/CgoKPiBJIHNwbGl0IHRoZSBsaW5l IGludG8gbWVtcGFyc2UgYW5kIHNoaWZ0aW5nIGFuZCBpbnNlcnRlZCBkaWFnbm9zdGljCj4gbWVz c2FnZXMsIG91dHB1dCB3aXRoIHVuaW5vcnRoX2FncC5hcGVydHVyZSA9IDMyIGFzIGJvb3QgcGFy YW1ldGVyOgo+IAo+IEZlYiAxNSAxOToxMjo0NCBtYWMtbWluaSBrZXJuZWw6IFsgICAgMi41Njg2 MzZdIGFncGdhcnQtdW5pbm9ydGgKPiAwMDAwOjAwOjBiLjA6IHNpemUgaW4gdW5pbm9ydGhfZmV0 Y2hfc2l6ZSBhZnRlciBtZW1wYXJzZTogMzIgRmViIDE1Cj4gMTk6MTI6NDQgbWFjLW1pbmkga2Vy bmVsOiBbICAgIDIuNTY4NjQyXSBhZ3BnYXJ0LXVuaW5vcnRoCj4gMDAwMDowMDowYi4wOiBzaXpl IGFmdGVyID4+IDIwOiAwCgpGb2xsb3dpbmcgeW91ciBtZW1wYXJzZSBsaW5rIHRvCmh0dHA6Ly9s eHIuZnJlZS1lbGVjdHJvbnMuY29tL3NvdXJjZS9saWIvY21kbGluZS5jI0wxMjcgLCB5b3UgY2Fu IHNlZQp0aGF0IHRoZSBtZW1wYXJzZSBmdW5jdGlvbiBzdXBwb3J0cyBzdWZmaWNlcyBzdWNoIGFz ICdNJyBvciAnbSc7IHdpdGhvdXQKc3VmZml4LCB0aGUgc2l6ZSBpcyBpbnRlcnByZXRlZCBhcyBi eXRlcy4KClNvIHlvdSBuZWVkIHNvbWV0aGluZyBsaWtlIHVuaW5vcnRoX2FncC5hcGVydHVyZT0z Mm0gLgoKCi0tIApFYXJ0aGxpbmcgTWljaGVsIETDpG56ZXIgICAgICAgICAgICAgICB8ICAgICAg ICAgICAgICAgaHR0cDovL3d3dy5hbWQuY29tCkxpYnJlIHNvZnR3YXJlIGVudGh1c2lhc3QgICAg ICAgICAgICAgfCAgICAgICAgICAgICBNZXNhIGFuZCBYIGRldmVsb3BlcgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=