From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14DEDC38A2A for ; Thu, 7 May 2020 17:16:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC1E02083B for ; Thu, 7 May 2020 17:16:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC1E02083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 184E36EA3B; Thu, 7 May 2020 17:16:17 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2539E6EA3B for ; Thu, 7 May 2020 17:16:16 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 892ACACC5; Thu, 7 May 2020 17:16:17 +0000 (UTC) Subject: Re: [PATCH 07/36] drm/gma500: Use lockless gem BO free callback To: Emil Velikov , dri-devel@lists.freedesktop.org References: <20200507150822.114464-1-emil.l.velikov@gmail.com> <20200507150822.114464-8-emil.l.velikov@gmail.com> From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= mQENBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAG0J1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPokBVAQTAQgAPhYh BHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJbOdLgAhsDBQkDwmcABQsJCAcCBhUKCQgLAgQWAgMB Ah4BAheAAAoJEGgNwR1TC3ojR80H/jH+vYavwQ+TvO8ksXL9JQWc3IFSiGpuSVXLCdg62AmR irxW+qCwNncNQyb9rd30gzdectSkPWL3KSqEResBe24IbA5/jSkPweJasgXtfhuyoeCJ6PXo clQQGKIoFIAEv1s8l0ggPZswvCinegl1diyJXUXmdEJRTWYAtxn/atut1o6Giv6D2qmYbXN7 mneMC5MzlLaJKUtoH7U/IjVw1sx2qtxAZGKVm4RZxPnMCp9E1MAr5t4dP5gJCIiqsdrVqI6i KupZstMxstPU//azmz7ZWWxT0JzgJqZSvPYx/SATeexTYBP47YFyri4jnsty2ErS91E6H8os Bv6pnSn7eAq5AQ0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRH UE9eosYbT6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgT RjP+qbU63Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+R dhgATnWWGKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zb ehDda8lvhFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r 12+lqdsAEQEAAYkBPAQYAQgAJhYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJbOdLgAhsMBQkD wmcAAAoJEGgNwR1TC3ojpfcIAInwP5OlcEKokTnHCiDTz4Ony4GnHRP2fXATQZCKxmu4AJY2 h9ifw9Nf2TjCZ6AMvC3thAN0rFDj55N9l4s1CpaDo4J+0fkrHuyNacnT206CeJV1E7NYntxU n+LSiRrOdywn6erjxRi9EYTVLCHcDhBEjKmFZfg4AM4GZMWX1lg0+eHbd5oL1as28WvvI/uI aMyV8RbyXot1r/8QLlWldU3NrTF5p7TMU2y3ZH2mf5suSKHAMtbE4jKJ8ZHFOo3GhLgjVrBW HE9JXO08xKkgD+w6v83+nomsEuf6C6LYrqY/tsZvyEX6zN8CtirPdPWu/VXNRYAl/lat7lSI 3H26qrE= Message-ID: <54ddd1ab-e723-cff3-8295-98690af6caaa@suse.de> Date: Thu, 7 May 2020 19:16:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200507150822.114464-8-emil.l.velikov@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter Content-Type: multipart/mixed; boundary="===============0729173355==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0729173355== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="a58XqSwQaz4xYmGZy2WZ2psaVtZIx8fmZ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --a58XqSwQaz4xYmGZy2WZ2psaVtZIx8fmZ Content-Type: multipart/mixed; boundary="uNz6qPRfWmvv1Kj9oRwQjJtDte5jD7hqU"; protected-headers="v1" From: Thomas Zimmermann To: Emil Velikov , dri-devel@lists.freedesktop.org Cc: Daniel Vetter Message-ID: <54ddd1ab-e723-cff3-8295-98690af6caaa@suse.de> Subject: Re: [PATCH 07/36] drm/gma500: Use lockless gem BO free callback References: <20200507150822.114464-1-emil.l.velikov@gmail.com> <20200507150822.114464-8-emil.l.velikov@gmail.com> In-Reply-To: <20200507150822.114464-8-emil.l.velikov@gmail.com> --uNz6qPRfWmvv1Kj9oRwQjJtDte5jD7hqU Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 07.05.20 um 17:07 schrieb Emil Velikov: > From: Emil Velikov >=20 > No dev->struct_mutex anywhere to be seen. >=20 > Cc: Patrik Jakobsson > Cc: Daniel Vetter > Signed-off-by: Emil Velikov > --- > drivers/gpu/drm/gma500/psb_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/= psb_drv.c > index 2411eb9827b8..34b4aae9a15e 100644 > --- a/drivers/gpu/drm/gma500/psb_drv.c > +++ b/drivers/gpu/drm/gma500/psb_drv.c > @@ -507,7 +507,7 @@ static struct drm_driver driver =3D { > .irq_uninstall =3D psb_irq_uninstall, > .irq_handler =3D psb_irq_handler, > =20 > - .gem_free_object =3D psb_gem_free_object, > + .gem_free_object_unlocked =3D psb_gem_free_object, I'd also rename the function to psb_gem_free_object_unlocked(). In any ca= se Reviewed-by: Thomas Zimmermann > .gem_vm_ops =3D &psb_gem_vm_ops, > =20 > .dumb_create =3D psb_gem_dumb_create, >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --uNz6qPRfWmvv1Kj9oRwQjJtDte5jD7hqU-- --a58XqSwQaz4xYmGZy2WZ2psaVtZIx8fmZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAl60QloACgkQaA3BHVML eiP2ewgAhVfU8Esqz20031yL/dxAzUHx9rImT285fClZmsuRVQUWcv8DiSRTZorQ HFVydocfLpf/Aw+bD3MFz+FtgvQgj/ZgtIUu1DD4Q4a/673FVfpNTopXUn12tLCM TuksT6MkZVGMxRcTLdMScFNS/RZs77wKVs3BEo2V4loL9j8ReAKJTO5YV2GVUwSS 5HhsxlLLm/r/i9iblDFmfmf3qLckaqMoDxC79cK8X2FprKFslABlx6gLW3ef4P5H PbZxk4iz48zuz3is03lVNONf9suxlqnsj8Zu2jozejjogBbNvWTw19PHv/bGoRZ7 zgZ409V0d79Wt2IHLPhwaUYCS9Azmg== =qdUk -----END PGP SIGNATURE----- --a58XqSwQaz4xYmGZy2WZ2psaVtZIx8fmZ-- --===============0729173355== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0729173355==--