From mboxrd@z Thu Jan  1 00:00:00 1970
From: Woody Suwalski <terraluna977@gmail.com>
Subject: Re: [PATCH v.2] 4.15 vmgfx boot warning
Date: Mon, 18 Dec 2017 19:26:03 -0500
Message-ID: <5508ddeb-ef4d-abfa-2573-717066448a43@gmail.com>
References: <c845316e-c0f8-9ef7-2bf5-97418d8094c7@gmail.com>
 <20171213212522.GC16788@promb-2n-dhcp36.eng.vmware.com>
 <1d88409f-23c4-6706-7111-00f2d13f3351@gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------E2306E517B9C0E1D3FEB1B12"
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1d88409f-23c4-6706-7111-00f2d13f3351@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Daniel Vetter <daniel.vetter@intel.com>
Cc: Sinclair Yeh <syeh@vmware.com>, DRI mailing list <dri-devel@lists.freedesktop.org>, LKML <linux-kernel@vger.kernel.org>, Dave Airlie <airlied@linux.ie>
List-Id: dri-devel@lists.freedesktop.org

This is a multi-part message in MIME format.
--------------E2306E517B9C0E1D3FEB1B12
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

The 4.15 drm_atomic_helper driver shows a warning during boot (both 32 
and 64 bit x86)
It is caused by a mismatch between the result of vmw_enable_vblank() and 
what the drm_atomic_helper expects:
    /...
    ret = drm_crtc_vblank_get(crtc);
    WARN_ONCE(ret != -EINVAL, "driver forgot to call 
drm_crtc_vblank_off()\n");
    /...

Signed-off by: Woody Suwalski <terraluna977@gmail.com>

--- a/drivers/gpu/drm/drm_atomic_helper.c    2017-12-16 
09:55:33.853374561 -0500
+++ b/drivers/gpu/drm/drm_atomic_helper.c    2017-12-16 
10:55:56.089090752 -0500
@@ -889,7 +889,7 @@ disable_outputs(struct drm_device *dev,
              continue;

          ret = drm_crtc_vblank_get(crtc);
-        WARN_ONCE(ret != -EINVAL, "driver forgot to call 
drm_crtc_vblank_off()\n");
+        WARN_ONCE((ret != -EINVAL && ret != -ENOSYS), "driver forgot to 
call drm_crtc_vblank_off()\n");
          if (ret == 0)
              drm_crtc_vblank_put(crtc);
      }


--------------E2306E517B9C0E1D3FEB1B12
Content-Type: text/x-patch;
 name="040_drm_atomic_helper.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="040_drm_atomic_helper.patch"

--- a/drivers/gpu/drm/drm_atomic_helper.c	2017-12-16 09:55:33.853374561 -0500
+++ b/drivers/gpu/drm/drm_atomic_helper.c	2017-12-16 10:55:56.089090752 -0500
@@ -889,7 +889,7 @@ disable_outputs(struct drm_device *dev,
 			continue;
 
 		ret = drm_crtc_vblank_get(crtc);
-		WARN_ONCE(ret != -EINVAL, "driver forgot to call drm_crtc_vblank_off()\n");
+		WARN_ONCE((ret != -EINVAL && ret != -ENOSYS), "driver forgot to call drm_crtc_vblank_off()\n");
 		if (ret == 0)
 			drm_crtc_vblank_put(crtc);
 	}

--------------E2306E517B9C0E1D3FEB1B12--