From: Emil Velikov <emil.l.velikov@gmail.com>
To: Damien Lespiau <damien.lespiau@intel.com>,
dri-devel@lists.freedesktop.org
Cc: emil.l.velikov@gmail.com
Subject: Re: [PATCH 1/3] RELEASING: Fix releasing instructions to match the latest release.sh
Date: Thu, 19 Mar 2015 17:39:06 +0000 [thread overview]
Message-ID: <550B09BA.2050908@gmail.com> (raw)
In-Reply-To: <1426782956-31214-2-git-send-email-damien.lespiau@intel.com>
On 19/03/15 16:35, Damien Lespiau wrote:
> It seems that the tests don't need DRM master anymore? at least make
> distcheck passes when X is running.
>
> release.sh is also invoked with just the path to the libdrm git checkout
> and we don't want to pass additional arguments that will be treated as
> additional modules we want to release.
>
> Also, make a note that release.sh will run make distcheck for you, so we
> don't strickly need to run it beforehand.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> RELEASING | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/RELEASING b/RELEASING
> index 3f07146..e17dbea 100644
> --- a/RELEASING
> +++ b/RELEASING
> @@ -20,13 +20,12 @@ Follow these steps to release a new version of libdrm:
> 4) Run autoconf and then re-run ./configure so the build system
> picks up the new version number.
>
> - 5) Verify that the code passes "make distcheck". libdrm is tricky
> - to distcheck since the test suite will need to become drm master.
> - This means that you need to run it outside X, that is, in text
> - mode (KMS or no KMS doesn't matter).
> + 5) (optional step, release.sh will make distcheck for you, but it can be
> + heart warming to verify that make distcheck passes)
>
> - Running "make distcheck" should result in no warnings or errors
> - and end with a message of the form:
> + Verify that the code passes "make distcheck". Running "make
> + distcheck" should result in no warnings or errors and end with a
> + message of the form:
>
Side note: Pretty sure that current make distcheck produces a handful of
warnings ;-)
Although we'll try to have them sorted by next release.
With my comment in patch 2 and Ilia's in 3 the series is
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
Thanks for the update.
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-03-19 17:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 16:35 [PATCH 0/3] A few fixes in the libdrm release documentation Damien Lespiau
2015-03-19 16:35 ` [PATCH 1/3] RELEASING: Fix releasing instructions to match the latest release.sh Damien Lespiau
2015-03-19 17:39 ` Emil Velikov [this message]
2015-03-20 15:57 ` Damien Lespiau
2015-03-19 16:35 ` [PATCH 2/3] RELEASING: Fix the step numbering Damien Lespiau
2015-03-19 17:32 ` Emil Velikov
2015-03-19 17:36 ` Damien Lespiau
2015-03-19 16:35 ` [PATCH 3/3] RELEASING: Fix annouce typo Damien Lespiau
2015-03-19 16:39 ` Ilia Mirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550B09BA.2050908@gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=damien.lespiau@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox