From: Emil Velikov <emil.l.velikov@gmail.com>
To: Jan Vesely <jan.vesely@rutgers.edu>
Cc: emil.l.velikov@gmail.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH libdrm 0/9] Rework remaining tests
Date: Thu, 26 Mar 2015 15:14:28 +0000 [thread overview]
Message-ID: <55142254.2000709@gmail.com> (raw)
In-Reply-To: <1427239208.3547.100.camel@rutgers.edu>
On 24/03/15 23:20, Jan Vesely wrote:
> On Sun, 2015-03-22 at 22:03 +0000, Emil Velikov wrote:
>> This series covers
>> - Remove the hackish "include xf86drmfoo.c" from dristat
>> - Extract the remaining two xf86drmfoo.c tests to standalone ones
>> - beat them into shape, and
>> - wire them up to make check.
>
> I finished going through the series. Feel free to ignore the internal
> header suggestions, I don;t think the risk of desynchronizing structures
> in test and implementation is real since few ppl will touch it anyway.
>
> drmHash test looks weird after cleanup.
> other than that looks good
>
Thanks I'll update the series (incorporating all of your comments), drop
patch 1 for now, and send it out in a bit.
-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-03-26 15:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-22 22:03 [PATCH libdrm 0/9] Rework remaining tests Emil Velikov
2015-03-22 22:03 ` [PATCH libdrm 1/9] tests/dristat: don't include C files Emil Velikov
2015-03-23 22:10 ` Jan Vesely
2015-03-26 14:59 ` Emil Velikov
2015-03-22 22:03 ` [PATCH libdrm 2/9] tests/hash: extract test out of xf86drmHash.c Emil Velikov
2015-03-23 22:27 ` Jan Vesely
2015-03-22 22:03 ` [PATCH libdrm 3/9] tests/hash: misc compilation fixes Emil Velikov
2015-03-23 22:42 ` Jan Vesely
2015-03-22 22:03 ` [PATCH libdrm 4/9] tests/hash: style fixes Emil Velikov
2015-03-23 22:46 ` Jan Vesely
2015-03-22 22:03 ` [PATCH libdrm 5/9] tests/hash: return non-zero on failure Emil Velikov
2015-03-23 23:08 ` Jan Vesely
2015-03-22 22:03 ` [PATCH libdrm 6/9] tests/random: extract test out of xf86drmRandom.c Emil Velikov
2015-03-24 22:10 ` Jan Vesely
2015-03-22 22:03 ` [PATCH libdrm 7/9] tests/random: return non-zero on test failure Emil Velikov
2015-03-24 22:12 ` Jan Vesely
2015-03-22 22:03 ` [PATCH libdrm 8/9] drm: replace HASH_DEBUG with DEBUG Emil Velikov
2015-03-24 0:01 ` Jan Vesely
2015-03-22 22:03 ` [PATCH libdrm 9/9] drm: use correct printf modifiers Emil Velikov
2015-03-24 0:04 ` Jan Vesely
2015-03-24 23:20 ` [PATCH libdrm 0/9] Rework remaining tests Jan Vesely
2015-03-26 15:14 ` Emil Velikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55142254.2000709@gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jan.vesely@rutgers.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox