From: Emil Velikov <emil.l.velikov@gmail.com>
To: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
Tobias Jakobi <liquid.acid@gmx.net>,
linux-samsung-soc@vger.kernel.org
Cc: emil.l.velikov@gmail.com, dri-devel@lists.freedesktop.org,
m.szyprowski@samsung.com
Subject: Re: [PATCH 1/5] tests/exynos: add fimg2d performance analysis
Date: Thu, 26 Mar 2015 15:16:04 +0000 [thread overview]
Message-ID: <551422B4.3010203@gmail.com> (raw)
In-Reply-To: <5512FE04.9000600@math.uni-bielefeld.de>
On 25/03/15 18:27, Tobias Jakobi wrote:
> Hello,
>
> the new version should fix most of the mentioned issues.
>
> Tobias Jakobi wrote:
>>> As a general note I would recommend keeping statements on separate lines
>>> (none of if (foo) far()) as it makes debugging easier.
>> OK, changing this.
> Except for this, I didn't change it since I don't see the point. In fact
> I think that splitting the few occurrences makes the code less readable.
>
Beauty is in the eye of the beholder.
> I haven't worked with getopt before, so I gave it a try and made all
> these hardcoded parameters configurable.
>
Nice :-)
Cheers,
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-03-26 15:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 22:25 drm/exynos: add async G2D execution to libdrm Tobias Jakobi
2015-03-20 22:25 ` [PATCH 1/5] tests/exynos: add fimg2d performance analysis Tobias Jakobi
2015-03-22 15:36 ` Emil Velikov
2015-03-22 16:35 ` Tobias Jakobi
2015-03-25 18:27 ` Tobias Jakobi
2015-03-26 15:16 ` Emil Velikov [this message]
2015-03-20 22:25 ` [PATCH 2/5] exynos: add EXYNOS_G2D_EVENT to drmHandleEvent Tobias Jakobi
2015-03-22 15:41 ` Emil Velikov
2015-03-22 16:29 ` Tobias Jakobi
2015-03-23 11:03 ` Emil Velikov
2015-03-30 0:02 ` Rob Clark
2015-03-30 11:37 ` Tobias Jakobi
2015-03-30 13:04 ` Tobias Jakobi
2015-04-21 18:14 ` Emil Velikov
2015-04-23 12:04 ` Tobias Jakobi
2015-03-20 22:25 ` [PATCH 3/5] exynos/fimg2d: add g2d_config_event Tobias Jakobi
2015-03-21 14:03 ` drm/exynos: add async G2D execution to libdrm Tobias Jakobi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551422B4.3010203@gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=liquid.acid@gmx.net \
--cc=m.szyprowski@samsung.com \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox