dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Alex Deucher <alexdeucher@gmail.com>, dri-devel@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>, emil.l.velikov@gmail.com
Subject: Re: [PATCH 1/4] drm: consolidate common list implementations
Date: Wed, 29 Apr 2015 19:26:22 +0000	[thread overview]
Message-ID: <5541305E.4070701@gmail.com> (raw)
In-Reply-To: <1429888431-27459-1-git-send-email-alexander.deucher@amd.com>

On 24/04/15 15:13, Alex Deucher wrote:
> This is used by radeon and freedreno and will be used
> by amdgpu.  I looked at switching to libdrm_lists.h,
> but it's pretty horrible.  E.g., DRMLISTFOREACHENTRYSAFE.
> 
It does have one advantage though - it's typeless. Thus it allows
nouveau and intel to have their custom list implementations. For example
 - struct nouveau_list (plain double list)
 - struct {mem_,}block (double list with some extra bookkeeping)

This change might cause small issues with Jerome's bof replay tool
(joujou), although I should have it merged with libdrm as this lands (or
shortly after).

With the comments sent out earlier for 3/4 (v4) and 4/4(v2), feel free
to add Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>, fwiw.

Thanks
Emil

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

      parent reply	other threads:[~2015-04-29 18:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-24 15:13 [PATCH 1/4] drm: consolidate common list implementations Alex Deucher
2015-04-24 15:13 ` [PATCH 2/4] drm: add util_math.h Alex Deucher
2015-04-24 15:13 ` [PATCH 3/4] drm: add libdrm_amdgpu (v3) Alex Deucher
2015-04-24 15:13 ` [PATCH 4/4] drm: add tests/amdgpu (v2) Alex Deucher
2015-04-29 13:15   ` Emil Velikov
2015-04-29 19:26 ` Emil Velikov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5541305E.4070701@gmail.com \
    --to=emil.l.velikov@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox