From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [RESEND PATCH 2/2] modetest: only select plane with matching format
Date: Thu, 21 May 2015 20:02:15 +0200 [thread overview]
Message-ID: <555E1DA7.60609@math.uni-bielefeld.de> (raw)
In-Reply-To: <CACvgo53MMcasx1xoqZx8WLUMYF6KmDSuq46mHNgerSVLzvc=fw@mail.gmail.com>
Hey Emil,
Emil Velikov wrote:
> Hi Tobias
>
> On 12 May 2015 at 21:17, Tobias Jakobi <tjakobi@math.uni-bielefeld.de> wrote:
>> Don't assume that a plane supports any kind of pixelformat
>> but do a check first.
>>
>> v2: Simplify the format check.
>> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> Nice catch ! I will push the tomorrow, unless we hear any objections against it.
>
> Patch 1/2 looks sane imho, although I'm not sure if some of the teams
> has some (automated?) testing which depends on the lack of
> transparency.
I'm not sure what you mean by that ('lack of transparency'). If you
create your primary plane with a XRGB-type format then this patch
doesn't change anything. If you create it with an ARGB-type format then
I can assume that the user wants an alpha-channel (he explicitly asks
for it).
With best wishes,
Tobias
> Curious if pinging people (check git log for a list) at
> #dri-devel or via email might show such users ?
>
> Cheers,
> Emil
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-05-21 18:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 20:17 [RESEND PATCH 1/2] modetest: make middle SMPTE colors transparent Tobias Jakobi
2015-05-12 20:17 ` [RESEND PATCH 2/2] modetest: only select plane with matching format Tobias Jakobi
2015-05-21 15:29 ` Emil Velikov
2015-05-21 18:02 ` Tobias Jakobi [this message]
2015-05-28 12:25 ` Emil Velikov
2015-06-11 13:43 ` Tobias Jakobi
2015-06-12 14:37 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555E1DA7.60609@math.uni-bielefeld.de \
--to=tjakobi@math.uni-bielefeld.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox