From: Emil Velikov <emil.l.velikov@gmail.com>
To: Martin Peres <martin.peres@free.fr>,
Alexandre Courbot <gnurou@gmail.com>,
Maarten Lankhorst <maarten@mblankhorst.nl>
Cc: "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
emil.l.velikov@gmail.com, Ben Skeggs <bskeggs@redhat.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [Nouveau] [PATCH v2] nouveau: add coherent BO attribute
Date: Tue, 26 May 2015 20:46:07 +0000 [thread overview]
Message-ID: <5564DB8F.3050405@gmail.com> (raw)
In-Reply-To: <5564C430.7000900@free.fr>
On 26/05/15 19:06, Martin Peres wrote:
> On 26/05/2015 16:23, Alexandre Courbot wrote:
>> On Sun, May 24, 2015 at 3:26 PM, Maarten Lankhorst
>> <maarten@mblankhorst.nl> wrote:
>>> Op 23-05-15 om 08:45 schreef Alexandre Courbot:
>>>> On Fri, May 22, 2015 at 3:23 AM, Martin Peres <martin.peres@free.fr>
>>>> wrote:
>>>>> On 21/05/2015 11:47, Ben Skeggs wrote:
>>>>>> On 21 May 2015 at 16:08, Alexandre Courbot <acourbot@nvidia.com>
>>>>>> wrote:
>>>>>>> Add a flag allowing Nouveau to specify that an object should be
>>>>>>> coherent
>>>>>>> at allocation time. This is required for some class of objects like
>>>>>>> fences which are randomly-accessed by both the CPU and GPU. This
>>>>>>> flag
>>>>>>> instructs the kernel driver to make sure the object remains coherent
>>>>>>> even on architectures for which coherency is not guaranteed by
>>>>>>> the bus.
>>>>>>>
>>>>>>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>>>>>> Reviewed-by: Ben Skeggs <bskeggs@redhat.com>
>>>>> Pushed!
>>>> Thanks! Should we also bump the ABI version or something?
>>> If you mean changing libdrm_nouveau.so.2 to .so.3 no! If you mean
>>> having something that pkg-config can pick up that's done
>>> automatically on every drm release.
>> Sorry for not having been clear. I was talking about checking against
>> the driver version to ensure it supports all the features that libdrm
>> can throw at it. We increased the modules's version to 1.2.2 when
>> adding the coherent flag:
>>
>> drm/nouveau/nouveau_drm.h:
>> * 1.2.2:
>> * - add NOUVEAU_GEM_DOMAIN_COHERENT flag
>
> That will be the job of mesa to check the DRM version, I would guess.
Precisely. It's up-to the user of nouveau_bo_new() to check for it.
Search for drm_version in src/gallium/drivers/nouveau to see how we
already do it for similar changes.
-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-05-26 20:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 6:08 [PATCH v2] nouveau: add coherent BO attribute Alexandre Courbot
[not found] ` <1432188508-650-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-05-21 8:47 ` Ben Skeggs
2015-05-21 18:23 ` [Nouveau] " Martin Peres
[not found] ` <555E228B.9090400-GANU6spQydw@public.gmane.org>
2015-05-23 6:45 ` Alexandre Courbot
[not found] ` <CAAVeFuJHL664jbsEBUYFp0atnuF3gisbwhJhR-R=cy+iB8gUCg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-24 6:26 ` Maarten Lankhorst
2015-05-26 13:23 ` [Nouveau] " Alexandre Courbot
[not found] ` <CAAVeFuJ4oNi-_ALd3NRNeje7wNntcJ5QME2TWHKTBVWzE0yG1w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-26 19:06 ` Martin Peres
2015-05-26 20:46 ` Emil Velikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5564DB8F.3050405@gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gnurou@gmail.com \
--cc=linux-tegra@vger.kernel.org \
--cc=maarten@mblankhorst.nl \
--cc=martin.peres@free.fr \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).