From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mario Kleiner Subject: Re: [PATCH] drm/nouveau: Use drm_vblank_on/off consistently Date: Wed, 17 Jun 2015 02:01:36 +0200 Message-ID: <5580B8E0.9010509@gmail.com> References: <1432717471-7879-1-git-send-email-daniel.vetter@ffwll.ch> <1434348449-28631-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTP id DD3FC6E9F4 for ; Tue, 16 Jun 2015 17:01:40 -0700 (PDT) Received: by wibdq8 with SMTP id dq8so35536004wib.1 for ; Tue, 16 Jun 2015 17:01:40 -0700 (PDT) In-Reply-To: <1434348449-28631-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , DRI Development Cc: Daniel Vetter , Ben Skeggs List-Id: dri-devel@lists.freedesktop.org CgpPbiAwNi8xNS8yMDE1IDA4OjA3IEFNLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+IEluCj4KPiBj b21taXQgOWNiYTVlZmFiNWE4MTQ1YWU2YzUyZWEyNzM1NTNmMDY5YzI5NDQ4Mgo+IEF1dGhvcjog TWFyaW8gS2xlaW5lciA8bWFyaW8ua2xlaW5lci5kZUBnbWFpbC5jb20+Cj4gRGF0ZTogICBUdWUg SnVsIDI5IDAyOjM2OjQ0IDIwMTQgKzAyMDAKPgo+ICAgICAgZHJtL25vdXZlYXU6IERpcy9FbmFi bGUgdmJsYW5rIGlycXMgZHVyaW5nIHN1c3BlbmQvcmVzdW1lCj4KPiBkcm1fdmJsYW5rX29uL29m ZiBjYWxscyB3aGVyZSBhZGRlZCBhcm91bmQgc3VzcGVuZC9yZXN1bWUgdG8gbWFrZSBzdXJlCj4g dmJsYW5rIHN0YXkgZG9lc24ndCBnbyBib29tIG92ZXIgdGhhdCB0cmFuc2l0aW9uLiBCdXQgbm91 dmVhdSBhbHJlYWR5Cj4gdXNlZCBkcm1fdmJsYW5rX3ByZS9wb3N0X21vZGVzZXQgb3ZlciBtb2Rl c2V0cy4gSW5zdGVhZCB1c2UKPiBkcm1fdmJsYW5rX29uL29mZiBldmVyeWh3ZXJlLiBUaGUgc2xp Z2h0IGNoYW5nZSBoZXJlIGlzIHRoYXQgYWZ0ZXIKPiBfb2ZmIGRybV92YmxhbmtfZ2V0IHdpbGwg cmVmdXNlIHRvIHdvcmsgcmlnaHQgYXdheSwgYnV0IG5vdXZlYXUKPiBkb2Vzbid0IHNlZW0gdG8g ZGVwZW5kIHVwb24gdGhhdCBhbnl3aGVyZSBvdXRzaWRlIG9mIHRoZSBwYWdlZmxpcAo+IHBhdGhz Lgo+Cj4gVGhlIGxvbmdlci10ZXJtIHBsYW4gaGVyZSBpcyB0byBzd2l0Y2ggYWxsIGttcyBkcml2 ZXJzIHRvCj4gZHJtX3ZibGFua19vbi9vZmYgc28gdGhhdCBjb21tb24gY29kZSBsaWtlIHBlbmRp bmcgZXZlbnQgY2xlYW51cCBjYW4KPiBiZSBkb25lIHRoZXJlLCB3aGlsZSBkcm1fdmJsYW5rX3By ZS9wb3N0X21vZGVzZXQgd2lsbCBiZSBwdXJlbHkKPiBkcm0gaW50ZXJuYWwgZm9yIHRoZSBvbGQg VU1TIGlvY3RsLgo+Cj4gTm90ZSB0aGF0IHRoZSBkcm1fdmJsYW5rX29mZiBzdGlsbCBzZWVtcyBy ZXF1aXJlZCBpbiB0aGUgc3VzcGVuZCBwYXRoCj4gc2luY2Ugbm91dmVhdSBkb2Vzbid0IGV4cGxp Y2l0bHkgZGlzYWJsZSBjcnRjcy4gQnV0IG9uIHRoZSByZXN1bWUgc2lkZQo+IGRybV9oZWxwZXJf cmVzdW1lX2ZvcmNlX21vZGUgc2hvdWxkIGVuZCB1cCBjYWxsaW5nIGRybV92Ymxhbmtfb24KPiB0 aHJvdWdoIHRoZSBub3V2ZWF1IGNydGMgaG9va3MgYWxyZWFkeS4gSGVuY2UgcmVtb3ZlIHRoZSBj YWxsIGluIHRoZQo+IHJlc3VtZSBjb2RlLgo+Cj4gdjI6IERvbid0IGZvcmdldCBhYm91dCBudjUw KywgcmVwb3J0ZWQgYnkgTWFyaW8uCj4KPiBUZXN0ZWQtYnk6IE1hcmlvIEtsZWluZXIgPG1hcmlv LmtsZWluZXIuZGVAZ21haWwuY29tPgo+IENjOiBNYXJpbyBLbGVpbmVyIDxtYXJpby5rbGVpbmVy LmRlQGdtYWlsLmNvbT4KPiBDYzogQmVuIFNrZWdncyA8YnNrZWdnc0ByZWRoYXQuY29tPgo+IFNp Z25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+IC0t LQo+ICAgZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvZGlzcG52MDQvY3J0Yy5jICAgfCA0ICsrLS0K PiAgIGRyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZlYXVfZGlzcGxheS5jIHwgNiArLS0tLS0K PiAgIGRyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L252NTBfZGlzcGxheS5jICAgIHwgOCArKysrKysr Kwo+ICAgMyBmaWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+ Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L2Rpc3BudjA0L2NydGMuYyBi L2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L2Rpc3BudjA0L2NydGMuYwo+IGluZGV4IDNkOTZiNDlm ZTY2Mi4uZGFiMjQwNjZmYTIxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1 L2Rpc3BudjA0L2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L2Rpc3BudjA0 L2NydGMuYwo+IEBAIC03MDgsNyArNzA4LDcgQEAgc3RhdGljIHZvaWQgbnZfY3J0Y19wcmVwYXJl KHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiAgIAlpZiAobnZfdHdvX2hlYWRzKGRldikpCj4gICAJ CU5WU2V0T3duZXIoZGV2LCBudl9jcnRjLT5pbmRleCk7Cj4KPiAtCWRybV92YmxhbmtfcHJlX21v ZGVzZXQoZGV2LCBudl9jcnRjLT5pbmRleCk7Cj4gKwlkcm1fdmJsYW5rX29mZihkZXYsIG52X2Ny dGMtPmluZGV4KTsKPiAgIAlmdW5jcy0+ZHBtcyhjcnRjLCBEUk1fTU9ERV9EUE1TX09GRik7Cj4K PiAgIAlOVkJsYW5rU2NyZWVuKGRldiwgbnZfY3J0Yy0+aW5kZXgsIHRydWUpOwo+IEBAIC03NDAs NyArNzQwLDcgQEAgc3RhdGljIHZvaWQgbnZfY3J0Y19jb21taXQoc3RydWN0IGRybV9jcnRjICpj cnRjKQo+ICAgI2VuZGlmCj4KPiAgIAlmdW5jcy0+ZHBtcyhjcnRjLCBEUk1fTU9ERV9EUE1TX09O KTsKPiAtCWRybV92YmxhbmtfcG9zdF9tb2Rlc2V0KGRldiwgbnZfY3J0Yy0+aW5kZXgpOwo+ICsJ ZHJtX3ZibGFua19vbihkZXYsIG52X2NydGMtPmluZGV4KTsKPiAgIH0KPgo+ICAgc3RhdGljIHZv aWQgbnZfY3J0Y19kZXN0cm95KHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbm91dmVhdV9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9k cm0vbm91dmVhdS9ub3V2ZWF1X2Rpc3BsYXkuYwo+IGluZGV4IDg2NzBkOTBjZGMxMS4uOWQyZDY0 N2RhM2FhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZlYXVfZGlz cGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbm91dmVhdV9kaXNwbGF5LmMK PiBAQCAtNTg0LDcgKzU4NCw3IEBAIG5vdXZlYXVfZGlzcGxheV9yZXN1bWUoc3RydWN0IGRybV9k ZXZpY2UgKmRldiwgYm9vbCBydW50aW1lKQo+ICAgewo+ICAgCXN0cnVjdCBub3V2ZWF1X2RybSAq ZHJtID0gbm91dmVhdV9kcm0oZGV2KTsKPiAgIAlzdHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4gLQlp bnQgcmV0LCBoZWFkOwo+ICsJaW50IHJldDsKPgo+ICAgCS8qIHJlLXBpbiBmYi9jdXJzb3JzICov Cj4gICAJbGlzdF9mb3JfZWFjaF9lbnRyeShjcnRjLCAmZGV2LT5tb2RlX2NvbmZpZy5jcnRjX2xp c3QsIGhlYWQpIHsKPiBAQCAtNjIwLDEwICs2MjAsNiBAQCBub3V2ZWF1X2Rpc3BsYXlfcmVzdW1l KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGJvb2wgcnVudGltZSkKPiAgIAkJbnZfY3J0Yy0+bHV0 LmRlcHRoID0gMDsKPiAgIAl9Cj4KPiAtCS8qIE1ha2Ugc3VyZSB0aGF0IGRybSBhbmQgaHcgdmJs YW5rIGlycXMgZ2V0IHJlc3VtZWQgaWYgbmVlZGVkLiAqLwo+IC0JZm9yIChoZWFkID0gMDsgaGVh ZCA8IGRldi0+bW9kZV9jb25maWcubnVtX2NydGM7IGhlYWQrKykKPiAtCQlkcm1fdmJsYW5rX29u KGRldiwgaGVhZCk7Cj4gLQo+ICAgCS8qIFRoaXMgc2hvdWxkIGVuc3VyZSB3ZSBkb24ndCBoaXQg YSBsb2NraW5nIHByb2JsZW0gd2hlbiBzb21lb25lCj4gICAJICogd2FrZXMgdXMgdXAgdmlhIGEg Y29ubmVjdG9yLiAgV2Ugc2hvdWxkIG5ldmVyIGdvIGludG8gc3VzcGVuZAo+ICAgCSAqIHdoaWxl IHRoZSBkaXNwbGF5IGlzIG9uIGFueXdheXMuCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9ub3V2ZWF1L252NTBfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbnY1MF9k aXNwbGF5LmMKPiBpbmRleCA3ZGE3OTU4NTU2YTMuLmExNmMzN2Q4ZjdlMSAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9udjUwX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9ub3V2ZWF1L252NTBfZGlzcGxheS5jCj4gQEAgLTk5Nyw2ICs5OTcsMTAgQEAgbnY1 MF9jcnRjX2N1cnNvcl9zaG93X2hpZGUoc3RydWN0IG5vdXZlYXVfY3J0YyAqbnZfY3J0YywgYm9v bCBzaG93LCBib29sIHVwZGF0ZSkKPiAgIHN0YXRpYyB2b2lkCj4gICBudjUwX2NydGNfZHBtcyhz dHJ1Y3QgZHJtX2NydGMgKmNydGMsIGludCBtb2RlKQo+ICAgewo+ICsJaWYgKG1vZGUgPT0gRFJN X01PREVfRFBNU19PTikKPiArCQlkcm1fY3J0Y192Ymxhbmtfb24oY3J0Yyk7Cj4gKwllbHNlCj4g KwkJZHJtX2NydGNfdmJsYW5rX29mZihjcnRjKTsKPiAgIH0KPgo+ICAgc3RhdGljIHZvaWQKPiBA QCAtMTAzNiw2ICsxMDQwLDggQEAgbnY1MF9jcnRjX3ByZXBhcmUoc3RydWN0IGRybV9jcnRjICpj cnRjKQo+ICAgCX0KPgo+ICAgCW52NTBfY3J0Y19jdXJzb3Jfc2hvd19oaWRlKG52X2NydGMsIGZh bHNlLCBmYWxzZSk7Cj4gKwo+ICsJZHJtX2NydGNfdmJsYW5rX29uKGNydGMpOwo+ICAgfQo+Cj4g ICBzdGF0aWMgdm9pZAo+IEBAIC0xMDQ1LDYgKzEwNTEsOCBAQCBudjUwX2NydGNfY29tbWl0KHN0 cnVjdCBkcm1fY3J0YyAqY3J0YykKPiAgIAlzdHJ1Y3QgbnY1MF9tYXN0ICptYXN0ID0gbnY1MF9t YXN0KGNydGMtPmRldik7Cj4gICAJdTMyICpwdXNoOwo+Cj4gKwlkcm1fY3J0Y192Ymxhbmtfb24o Y3J0Yyk7Cj4gKwo+ICAgCXB1c2ggPSBldm9fd2FpdChtYXN0LCAzMik7Cj4gICAJaWYgKHB1c2gp IHsKPiAgIAkJaWYgKG52NTBfdmVycyhtYXN0KSA8IEc4Ml9ESVNQX0NPUkVfQ0hBTk5FTF9ETUEp IHsKPgoKVGhpcyBpcwoKUmV2aWV3ZWQtYW5kLXRlc3RlZC1ieTogTWFyaW8gS2xlaW5lciA8bWFy aW8ua2xlaW5lci5kZUBnbWFpbC5jb20+CgotbWFyaW8KCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg==