From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: David Airlie <airlied@linux.ie>,
Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
Andy Yan <andy.yan@rock-chips.com>,
dri-devel@lists.freedesktop.org, Yakir Yang <ykk@rock-chips.com>
Subject: Re: [PATCH 1/2] drm: bridge/dw_hdmi: fix register I2CM_ADDRESS register name
Date: Fri, 26 Jun 2015 17:24:12 +0300 [thread overview]
Message-ID: <558D608C.7080003@mentor.com> (raw)
In-Reply-To: <5575A412.4070308@mentor.com>
Hello David,
On 08.06.2015 17:17, Vladimir Zapolskiy wrote:
> Hi David, Philipp, Andy, Russell,
>
> On 19.05.2015 17:39, Andy Yan wrote:
>> Hi Vladimir,
>> Thanks for you patch.
>>
>> On 2015年05月18日 20:32, Vladimir Zapolskiy wrote:
>>> I2CM_ADDRESS became a MESS, fix it, also change guarding define
>>> to __DW_HDMI_H__ , since the driver is not IMX specific.
>>>
>>> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
>> Acked-by: Andy Yan <andy.yan@rock-chips.com>
>>> ---
>>> drivers/gpu/drm/bridge/dw_hdmi.h | 8 ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.h b/drivers/gpu/drm/bridge/dw_hdmi.h
>>> index 175dbc8..ee7f7ed 100644
>>> --- a/drivers/gpu/drm/bridge/dw_hdmi.h
>>> +++ b/drivers/gpu/drm/bridge/dw_hdmi.h
>>> @@ -7,8 +7,8 @@
>>> * (at your option) any later version.
>>> */
>>>
>>> -#ifndef __IMX_HDMI_H__
>>> -#define __IMX_HDMI_H__
>>> +#ifndef __DW_HDMI_H__
>>> +#define __DW_HDMI_H__
>>>
>>> /* Identification Registers */
>>> #define HDMI_DESIGN_ID 0x0000
>>> @@ -525,7 +525,7 @@
>>>
>>> /* I2C Master Registers (E-DDC) */
>>> #define HDMI_I2CM_SLAVE 0x7E00
>>> -#define HDMI_I2CMESS 0x7E01
>>> +#define HDMI_I2CM_ADDRESS 0x7E01
>>> #define HDMI_I2CM_DATAO 0x7E02
>>> #define HDMI_I2CM_DATAI 0x7E03
>>> #define HDMI_I2CM_OPERATION 0x7E04
>>> @@ -1031,4 +1031,4 @@ enum {
>>> HDMI_A_VIDPOLCFG_HSYNCPOL_ACTIVE_LOW = 0x0,
>>> };
>>>
>>> -#endif /* __IMX_HDMI_H__ */
>>> +#endif /* __DW_HDMI_H__ */
>>
>>
>
> what would be the next action regarding these two patches? If review is
> done, should they go to drm-dwhdmi-devel or drm-next ?
ping.
--
With best wishes,
Vladimir
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-06-26 14:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 12:32 [PATCH v2 0/2] drm: bridge/dw_hdmi: add I2C bus adapter support Vladimir Zapolskiy
2015-05-18 12:32 ` [PATCH 1/2] drm: bridge/dw_hdmi: fix register I2CM_ADDRESS register name Vladimir Zapolskiy
2015-05-19 9:42 ` Philipp Zabel
2015-05-19 10:42 ` Philipp Zabel
2015-05-19 14:39 ` Andy Yan
2015-06-08 14:17 ` Vladimir Zapolskiy
2015-06-26 14:24 ` Vladimir Zapolskiy [this message]
2015-06-26 15:02 ` Russell King - ARM Linux
2015-07-24 15:09 ` Vladimir Zapolskiy
2015-08-13 21:35 ` Vladimir Zapolskiy
2015-05-18 12:32 ` [PATCH v2 2/2] drm: bridge/dw_hdmi: add dw hdmi i2c bus adapter support Vladimir Zapolskiy
2015-05-19 10:43 ` Philipp Zabel
2015-08-13 22:56 ` Russell King - ARM Linux
2015-08-29 22:37 ` Vladimir Zapolskiy
-- strict thread matches above, loose matches on Subject: below --
2015-05-17 18:03 [PATCH 0/2] drm: bridge/dw_hdmi: add I2C " Vladimir Zapolskiy
2015-05-17 18:03 ` [PATCH 1/2] drm: bridge/dw_hdmi: fix register I2CM_ADDRESS register name Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558D608C.7080003@mentor.com \
--to=vladimir_zapolskiy@mentor.com \
--cc=airlied@linux.ie \
--cc=andy.yan@rock-chips.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@freescale.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox