From: "Michel Dänzer" <michel@daenzer.net>
To: Jerome Glisse <j.glisse@gmail.com>
Cc: Thomas Hellstrom <thellstrom@vmware.com>,
Jack.Xiao@amd.com, dri-devel@lists.freedesktop.org,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 2/3] drm/ttm: fix object deallocation to properly fill in the page pool.
Date: Wed, 8 Jul 2015 11:34:45 +0900 [thread overview]
Message-ID: <559C8C45.2090007@daenzer.net> (raw)
In-Reply-To: <20150707174158.GB12288@gmail.com>
On 08.07.2015 02:41, Jerome Glisse wrote:
> On Tue, Jul 07, 2015 at 03:39:29PM +0900, Michel Dänzer wrote:
>> On 07.07.2015 01:10, Jerome Glisse wrote:
>>>
>>> In meantime i think we need to apply this patch as it is really a fix to
>>> make the code actually do what the comment and design pretends it does.
>>
>> I agree.
>>
>> BTW, maybe it should be split up into the actual fix (removing the
>> npages assignment) and the NUM_PAGES_TO_ALLOC related simplification?
>
> This would make 2 really small patch, patch is small as it is :) But why
> not.
It's not about size but about having one commit for each logical change.
It took me a while to realize that the NUM_PAGES_TO_ALLOC changes aren't
directly related to the fix, and I've seen the same thing happen to others.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-08 2:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 3:52 [PATCH 0/3] drm/ttm: hard to swim in an empty pool Jérôme Glisse
2014-08-13 3:52 ` [PATCH 1/3] drm/ttm: set sensible pool size limit Jérôme Glisse
2014-08-13 6:24 ` Michel Dänzer
2014-08-13 3:52 ` [PATCH 2/3] drm/ttm: fix object deallocation to properly fill in the page pool Jérôme Glisse
2015-03-25 19:06 ` Konrad Rzeszutek Wilk
2015-07-06 9:11 ` Michel Dänzer
2015-07-06 16:10 ` Jerome Glisse
2015-07-07 6:39 ` Michel Dänzer
2015-07-07 17:41 ` Jerome Glisse
2015-07-08 2:34 ` Michel Dänzer [this message]
2014-08-13 3:52 ` [PATCH 3/3] drm/ttm: under memory pressure minimize the size of memory pool Jérôme Glisse
2014-08-13 6:32 ` Michel Dänzer
2014-08-13 9:06 ` Thomas Hellstrom
2014-08-13 10:42 ` Daniel Vetter
2014-08-13 12:35 ` GEM memory DOS (WAS Re: [PATCH 3/3] drm/ttm: under memory pressure minimize the size of memory pool) Thomas Hellstrom
2014-08-13 12:40 ` David Herrmann
2014-08-13 12:48 ` Thomas Hellstrom
2014-08-13 13:01 ` Daniel Vetter
2014-08-13 14:09 ` Oded Gabbay
2014-08-13 15:19 ` Thomas Hellstrom
2014-08-13 16:30 ` Daniel Vetter
2014-08-13 15:13 ` Thomas Hellstrom
2014-08-13 16:24 ` Daniel Vetter
2014-08-13 16:30 ` Alex Deucher
2014-08-13 16:38 ` Daniel Vetter
2014-08-13 16:45 ` Daniel Vetter
2014-08-13 17:38 ` Thomas Hellstrom
2014-08-13 17:20 ` Thomas Hellstrom
2014-08-14 22:29 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559C8C45.2090007@daenzer.net \
--to=michel@daenzer.net \
--cc=Jack.Xiao@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=j.glisse@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox