From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonyoung Shim Subject: Re: [PATCH v2 12/23] drm/exynos: don't track enabled state at exynos_crtc Date: Fri, 10 Jul 2015 09:47:37 +0900 Message-ID: <559F1629.2060300@samsung.com> References: <1436192424-18194-1-git-send-email-gustavo@padovan.org> <1436192424-18194-13-git-send-email-gustavo@padovan.org> <20150706174147.GB7568@phenom.ffwll.local> <559E2C4C.9030603@samsung.com> <20150709225600.GA2000@joana> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20150709225600.GA2000@joana> Sender: linux-samsung-soc-owner@vger.kernel.org To: Gustavo Padovan , Daniel Vetter , linux-samsung-soc@vger.kernel.org, tjakobi@math.uni-bielefeld.de, Gustavo Padovan , dri-devel@lists.freedesktop.org, Andrzej Hajda List-Id: dri-devel@lists.freedesktop.org On 07/10/2015 07:56 AM, Gustavo Padovan wrote: > 2015-07-09 Joonyoung Shim : > >> +Cc Andrzej, >> >> On 07/07/2015 02:41 AM, Daniel Vetter wrote: >>> On Mon, Jul 06, 2015 at 11:20:13AM -0300, Gustavo Padovan wrote: >>>> From: Gustavo Padovan >>>> >>>> struct drm_crtc already stores the enabled state of the crtc >>>> thus we don't need to replicate enabled in exynos_drm_crtc. >>>> >> >> I think exynos_crtc->enabled can replace flags for power state of each >> hw driver(e.g. "powered" of mixer driver, "suspended" of fimd driver). >> Further, we can add other flag bit for instead of using special flag >> in hw driver like vsync state("int_en" of mixer driver, "irq_flags" of >> fimd driver.) > > The reason I removed it is because crtc->state->active already stores > the same information as exynos_crtc->enabled. I think we could rely > on active as well for mixer powered and suspended. > Then it may need another stuff on struct exynos_crtc if we try to replace other hw flag like int_en or irq_flags. Anyway, the reason that you remove it is ok to me now. Thanks.