From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v1.1 2/5] drm/atomic: Make prepare_fb/cleanup_fb only take state, v2.
Date: Mon, 27 Jul 2015 13:55:29 +0200 [thread overview]
Message-ID: <55B61C31.3040007@linux.intel.com> (raw)
In-Reply-To: <20150727111415.GS16722@phenom.ffwll.local>
Hey,
Op 27-07-15 om 13:14 schreef Daniel Vetter:
> On Mon, Jul 27, 2015 at 01:07:37PM +0200, Maarten Lankhorst wrote:
>> Op 27-07-15 om 09:53 schreef Daniel Vetter:
>>> On Wed, Jul 22, 2015 at 09:23:27AM -0400, Rob Clark wrote:
>>>> On Thu, Jul 16, 2015 at 10:13 AM, Maarten Lankhorst
>>>> <maarten.lankhorst@linux.intel.com> wrote:
>>>>> This removes the need to separately track fb changes i915.
>>>>>
>>>>> Changes since v1:
>>>>> - Add dri-devel to cc.
>>>>> - Fix a check in intel's prepare and cleanup fb to take rotation
>>>>> into account.
>>>>>
>>>>> Cc: dri-devel@lists.freedesktop.org
>>>>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>>> Reviewed-by: Rob Clark <robdclark@gmail.com>
>>> Applied to drm-misc, thanks.
>>> -Daniel
>> This one needs i915 converted to atomic first, or dpms will fail. :(
> Yeah I dropped it again, since it also does some shuffling in i915 code.
> That should be done in a split-out patch so that this one here really only
> removes the fb parameter.
> -Daniel
The code shuffling is a consequence of removing the fb parameter and allowing NULL.
If you want to separate it that's possible, but means returning early in prepare_plane_fb while a followup patch copes with a nil fb.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-07-27 11:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1437051471-15397-1-git-send-email-maarten.lankhorst@linux.intel.com>
[not found] ` <1437051471-15397-3-git-send-email-maarten.lankhorst@linux.intel.com>
2015-07-16 14:13 ` [PATCH v1.1 2/5] drm/atomic: Make prepare_fb/cleanup_fb only take state, v2 Maarten Lankhorst
2015-07-22 13:23 ` Rob Clark
2015-07-27 7:53 ` [Intel-gfx] " Daniel Vetter
2015-07-27 11:07 ` Maarten Lankhorst
2015-07-27 11:14 ` Daniel Vetter
2015-07-27 11:55 ` Maarten Lankhorst [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B61C31.3040007@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox