From: "Christian König" <deathsimple@vodafone.de>
To: "Thierry Reding" <thierry.reding@gmail.com>,
"Christian König" <christian.koenig@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>
Cc: Boyuan Zhang <boyuan.zhang@amd.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Avoid possibly uninitialized variable
Date: Fri, 14 Aug 2015 14:35:45 +0200 [thread overview]
Message-ID: <55CDE0A1.4020806@vodafone.de> (raw)
In-Reply-To: <1439553148-2690-1-git-send-email-thierry.reding@gmail.com>
On 14.08.2015 13:52, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The min_ctx_size is only initialized for H265, so garbage will end up in
> buf_sizes[4] for all other stream types. Better initialize the value to
> 0 to avoid unpleasant surprises.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
We already stumbled over this internally as well, not sure if Alex is
going to merge your patch or the internal version.
Regards,
Christian.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> index f5c22556ec2c..91e79c3f2403 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> @@ -374,7 +374,7 @@ static int amdgpu_uvd_cs_msg_decode(uint32_t *msg, unsigned buf_sizes[])
> unsigned height_in_mb = ALIGN(height / 16, 2);
> unsigned fs_in_mb = width_in_mb * height_in_mb;
>
> - unsigned image_size, tmp, min_dpb_size, num_dpb_buffer, min_ctx_size;
> + unsigned image_size, tmp, min_dpb_size, num_dpb_buffer, min_ctx_size = 0;
>
> image_size = width * height;
> image_size += image_size / 2;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-08-14 12:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 11:52 [PATCH] drm/amdgpu: Avoid possibly uninitialized variable Thierry Reding
2015-08-14 12:35 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CDE0A1.4020806@vodafone.de \
--to=deathsimple@vodafone.de \
--cc=alexander.deucher@amd.com \
--cc=boyuan.zhang@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox