Re: [PATCH] drm/tilcdc: panel: Add tilcdc- prefix to driver name

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1392 bytes --]


On 29/07/15 13:12, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> The current driver name, "panel", is very generic. This causes problems
> when the driver is enabled on non-TI device tree platforms if the panel
> node is called "panel". This causes the driver name match fall-back in
> platform_match() to succeed, even if some other driver would precisely
> match using the OF device ID table, for example.
> 
> Currently there don't seem to be any in-tree users that rely on the
> driver name match, so adding the prefix should be safe.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index 7a0315855e90..375505caf9c7 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -460,7 +460,7 @@ struct platform_driver panel_driver = {
>  	.remove = panel_remove,
>  	.driver = {
>  		.owner = THIS_MODULE,
> -		.name = "panel",
> +		.name = "tilcdc-panel",
>  		.of_match_table = panel_of_match,
>  	},
>  };

I didn't know we do matching based on the node name also...

This looks fine, I believe the tilcdc is only used with DT based
systems. I'll pick this up.

 Tomi


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel