From: Tiago Vignatti <tiago.vignatti@intel.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: "Jérôme Glisse" <jglisse@redhat.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Thomas Hellstrom" <thellstrom@vmware.com>,
"ML dri-devel" <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/6] drm: prime: Honour O_RDWR during prime-handle-to-fd
Date: Thu, 27 Aug 2015 15:19:40 -0300 [thread overview]
Message-ID: <55DF54BC.6010807@intel.com> (raw)
In-Reply-To: <CACvgo53_gNNpnA-ODfBjaqacMJwKW+UV41_11H3AfyBir1uwpQ@mail.gmail.com>
On 08/27/2015 01:36 PM, Emil Velikov wrote:
> Hi all,
>
> On 27 August 2015 at 00:29, Tiago Vignatti <tiago.vignatti@intel.com> wrote:
>> From: Daniel Thompson <daniel.thompson@linaro.org>
>>
>> Currently DRM_IOCTL_PRIME_HANDLE_TO_FD rejects all flags except
>> (DRM|O)_CLOEXEC making it difficult (maybe impossible) for userspace
>> to mmap() the resulting dma-buf even when this is supported by the
>> DRM driver.
>>
>> It is trivial to relax the restriction and permit read/write access.
>> This is safe because the flags are seldom touched by drm; mostly they
>> are passed verbatim to dma_buf calls.
>>
> Strictly speaking shouldn't this patch be the last one in the series ?
> I.e. we should lift this restriction, after the sync method
> (ioctl/syscall/etc.) is in place. Or perhaps I missed something ?
I think you're right about it, Emil.
Thank you,
Tiago
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-08-27 18:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 23:29 [PATCH v5] mmap on the dma-buf directly Tiago Vignatti
2015-08-26 23:29 ` [PATCH 1/6] drm: prime: Honour O_RDWR during prime-handle-to-fd Tiago Vignatti
2015-08-27 16:36 ` Emil Velikov
2015-08-27 18:19 ` Tiago Vignatti [this message]
2015-08-26 23:29 ` [PATCH 2/6] dma-buf: Remove range-based flush Tiago Vignatti
2015-08-26 23:29 ` [PATCH 3/6] dma-buf: Add ioctls to allow userspace to flush Tiago Vignatti
2015-08-27 8:03 ` Chris Wilson
2015-08-27 19:58 ` Tiago Vignatti
2015-08-27 12:06 ` Hwang, Dongseong
2015-08-27 19:53 ` Tiago Vignatti
2015-08-26 23:29 ` [PATCH 4/6] dma-buf: DRAFT: Make SYNC mandatory when userspace mmap Tiago Vignatti
2015-08-26 23:29 ` [PATCH 5/6] drm/i915: Implement end_cpu_access Tiago Vignatti
2015-08-26 23:29 ` [PATCH 6/6] drm/i915: Use CPU mapping for userspace dma-buf mmap() Tiago Vignatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DF54BC.6010807@intel.com \
--to=tiago.vignatti@intel.com \
--cc=daniel.thompson@linaro.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=jglisse@redhat.com \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox