From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH 04/14] exynos/fimg2d: check buffer space in g2d_solid_fill() Date: Tue, 01 Sep 2015 09:41:22 +0900 Message-ID: <55E4F432.1080600@samsung.com> References: <1440425649-9768-1-git-send-email-tjakobi@math.uni-bielefeld.de> <1440425649-9768-5-git-send-email-tjakobi@math.uni-bielefeld.de> <55E45029.40009@samsung.com> <55E4AA97.2070502@math.uni-bielefeld.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: Sender: linux-samsung-soc-owner@vger.kernel.org To: Emil Velikov , Tobias Jakobi Cc: "moderated list:ARM/S5P EXYNOS AR..." , ML dri-devel , Joonyoung Shim , gustavo.padovan@collabora.co.uk List-Id: dri-devel@lists.freedesktop.org On 2015=EB=85=84 09=EC=9B=94 01=EC=9D=BC 04:57, Emil Velikov wrote: > On 31 August 2015 at 20:27, Tobias Jakobi wrote: >> Hello! >> >> Inki Dae wrote: >>> On 2015=EB=85=84 08=EC=9B=94 24=EC=9D=BC 23:13, Tobias Jakobi wrote= : >=20 >>>> + if (g2d_check_space(ctx, 7, 1)) >>>> + return -ENOSPC; >>> >>> You can make 3 and 4 patches to one. These should be same patch. >> Hmm, so which 3 (respectively 4) patches should be squashed? >> > I believe he meant "squash the introduction of the function and its > uses into a single patch". >=20 > Not sure how much value that brings, so I'll let you guys decide on > the bike shed colour :-) That - including relevant my comments - is just my opinion so no proble= m to upstream it as is. This is really trivial. Thanks, Inki Dae >=20 > -Emil > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsu= ng-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >=20