From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH] drm/mgag200: fix memory leak Date: Mon, 14 Sep 2015 20:53:57 +0530 Message-ID: <55F6E68D.8070800@codeaurora.org> References: <1441627110-13783-1-git-send-email-sudipm.mukherjee@gmail.com> <20150913093607.GA6074@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by gabe.freedesktop.org (Postfix) with ESMTPS id DAFB36E8B8 for ; Mon, 14 Sep 2015 08:24:09 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dave Airlie , Ingo Molnar Cc: Daniel Vetter , LKML , dri-devel , Archit Taneja , Sudip Mukherjee List-Id: dri-devel@lists.freedesktop.org SGksCgpPbiA5LzE0LzIwMTUgMzozNSBQTSwgRGF2ZSBBaXJsaWUgd3JvdGU6Cj4gKHRoaXMgdGlt ZSB3aXRoIGNvcnJlY3QgZW1haWwgYWRkcmVzcykuCj4KPiBPbiAxNCBTZXB0ZW1iZXIgMjAxNSBh dCAyMDowNCwgRGF2ZSBBaXJsaWUgPGFpcmxpZWRAZ21haWwuY29tPiB3cm90ZToKPj4+Cj4+Pj4g SWYgZHJtX2ZiX2hlbHBlcl9hbGxvY19mYmkoKSBmYWlscyB0aGVuIHdlIHdlcmUgZGlyZWN0bHkg cmV0dXJuaW5nCj4+Pj4gd2l0aG91dCBmcmVlaW5nIHN5c3JhbS4gQWxzbyBpZiBkcm1fZmJfaGVs cGVyX2FsbG9jX2ZiaSgpIHN1Y2NlZWRzIGJ1dAo+Pj4+IG1nYWcyMDBfZnJhbWVidWZmZXJfaW5p dCgpIGZhaWxzIHRoZW4gd2Ugd2VyZSBub3QgcmVsZWFzaW5nIHN5c3JhbSBhbmQKPj4+PiB3ZSB3 ZXJlIG5vdCByZWxlYXNpbmcgZmJpIGhlbHBlciBhbHNvLgo+Pj4+Cj4+Pj4gU2lnbmVkLW9mZi1i eTogU3VkaXAgTXVraGVyamVlIDxzdWRpcEB2ZWN0b3JpbmRpYS5vcmc+Cj4+Pj4gLS0tCj4+Pj4g ICBkcml2ZXJzL2dwdS9kcm0vbWdhZzIwMC9tZ2FnMjAwX2ZiLmMgfCAxNSArKysrKysrKysrKyst LS0KPj4+PiAgIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygt KQo+Pj4+Cj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZ2FnMjAwL21nYWcyMDBf ZmIuYyBiL2RyaXZlcnMvZ3B1L2RybS9tZ2FnMjAwL21nYWcyMDBfZmIuYwo+Pj4+IGluZGV4IDg3 ZGUxNWUuLjVmZTQ3NmEgMTAwNjQ0Cj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21nYWcyMDAv bWdhZzIwMF9mYi5jCj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21nYWcyMDAvbWdhZzIwMF9m Yi5jCj4+Pj4gQEAgLTE4OSwxNCArMTg5LDE2IEBAIHN0YXRpYyBpbnQgbWdhZzIwMGZiX2NyZWF0 ZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqaGVscGVyLAo+Pj4+ICAgICAgICAgICAgICAgIHJldHVy biAtRU5PTUVNOwo+Pj4+Cj4+Pj4gICAgICAgIGluZm8gPSBkcm1fZmJfaGVscGVyX2FsbG9jX2Zi aShoZWxwZXIpOwo+Pj4+IC0gICAgIGlmIChJU19FUlIoaW5mbykpCj4+Pj4gLSAgICAgICAgICAg ICByZXR1cm4gUFRSX0VSUihpbmZvKTsKPj4+PiArICAgICBpZiAoSVNfRVJSKGluZm8pKSB7Cj4+ Pj4gKyAgICAgICAgICAgICByZXQgPSBQVFJfRVJSKGluZm8pOwo+Pj4+ICsgICAgICAgICAgICAg Z290byBlcnJfYWxsb2NfZmJpOwo+Pj4+ICsgICAgIH0KPj4+Pgo+Pj4+ICAgICAgICBpbmZvLT5w YXIgPSBtZmJkZXY7Cj4+Pj4KPj4+PiAgICAgICAgcmV0ID0gbWdhZzIwMF9mcmFtZWJ1ZmZlcl9p bml0KGRldiwgJm1mYmRldi0+bWZiLCAmbW9kZV9jbWQsIGdvYmopOwo+Pj4+ICAgICAgICBpZiAo cmV0KQo+Pj4+IC0gICAgICAgICAgICAgcmV0dXJuIHJldDsKPj4+PiArICAgICAgICAgICAgIGdv dG8gZXJyX2ZyYW1lYnVmZmVyX2luaXQ7Cj4+Pj4KPj4+PiAgICAgICAgbWZiZGV2LT5zeXNyYW0g PSBzeXNyYW07Cj4+Pj4gICAgICAgIG1mYmRldi0+c2l6ZSA9IHNpemU7Cj4+Pj4gQEAgLTIyNiw2 ICsyMjgsMTMgQEAgc3RhdGljIGludCBtZ2FnMjAwZmJfY3JlYXRlKHN0cnVjdCBkcm1fZmJfaGVs cGVyICpoZWxwZXIsCj4+Pj4gICAgICAgIERSTV9ERUJVR19LTVMoImFsbG9jYXRlZCAlZHglZFxu IiwKPj4+PiAgICAgICAgICAgICAgICAgICAgICBmYi0+d2lkdGgsIGZiLT5oZWlnaHQpOwo+Pj4+ ICAgICAgICByZXR1cm4gMDsKPj4+PiArCj4+Pj4gK2Vycl9mcmFtZWJ1ZmZlcl9pbml0Ogo+Pj4+ ICsgICAgIGRybV9mYl9oZWxwZXJfcmVsZWFzZV9mYmkoaGVscGVyKTsKPj4+PiArCj4+Pj4gK2Vy cl9hbGxvY19mYmk6Cj4+Pj4gKyAgICAgdmZyZWUoc3lzcmFtKTsKPj4+PiArICAgICByZXR1cm4g cmV0Owo+Pj4+ICAgfQo+Pj4+Cj4+Pj4gICBzdGF0aWMgaW50IG1nYV9mYmRldl9kZXN0cm95KHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+Pgo+Pj4gVGhlcmUncyBhIG5ldyByZWdyZXNzaW9uOiB2 NC4zLXJjMSBjcmFzaGVzIG9uIGJvb3R1cCBvbiBub24tc3VwcG9ydGVkIGhhcmR3YXJlLCBpZgo+ Pj4gQ09ORklHX0RSTV9NR0FHMjAwPXkgKGJ1aWx0IGludG8gdGhlIGtlcm5lbCkuCj4+Cj4+IEFy Y2hpdCwgSSdtIGd1ZXNzaW5nIHRoaXMgaXMgc29tZSBmYWxsb3V0IGZyb20gdGhlIGZiZGV2IGNo YW5nZXMuCj4+Cj4+IFRoZXJlIGlzIG5vIHJlYXNvbiB3ZSBzaG91bGQgbmVlZCBDT05GSUdfRkJf TElUVExFX0VORElBTiBJIGRvbid0IHRoaW5rLgoKSXQgbG9va3MgbGlrZSB0aGUgbWdhZzIwMCBk cml2ZXIgbG9hZCBmYWlscyBhbmQgd2UgY3Jhc2ggaW4gdGhlIGVycm9yIApoYW5kbGluZyBwYXRo LiBkcm1fZmJfaGVscGVyX2ZpbmkgZW5kcyB1cCBiZWluZyBjYWxsZWQgdHdpY2UuIFRoZSBzZWNv bmQKY2FsbCB0cmllcyB0byBmcmVlIHJlc291cmNlcyB0aGF0IHdlcmUgYWxyZWFkeSBmcmVlJ2Qu CgpUaGUgZXJyb25lb3VzIHBhdGggYWJvdmUgc2hvdWxkIGhhdmUgZXhpc3RlZCBldmVuIHdpdGhv dXQgdGhlIHJlY2VudApmYmRldiBoZWxwZXIgY2hhbmdlcy4gSSdtIG5vdCBzdXJlIHdoYXQncyBj YXVzaW5nIHRoZSBkcml2ZXIgbG9hZAp0byBmYWlsIGluIHRoZSBmaXJzdCBwbGFjZS4gSXQgbG9v a3MgbGlrZSBpdCdzIGZhaWxpbmcgYXQKcmVnaXN0ZXJfZnJhbWVidWZmZXIuIElzIGl0IHBvc3Np YmxlIHRoYXQgd2UgbmV2ZXIgdHJpZWQgcnVubmluZwp0aGlzIGRyaXZlciBiZWZvcmUgd2l0aCBC aWcgRW5kaWFuIHNldD8KClRoZSBwYXRjaCBiZWxvdyBmaXhlcyB0aGUgcHJvYmxlbSB3aXRoIHRo ZSBlcnJvciBwYXRoIG1lbnRpb25lZAphYm92ZS4gQ291bGQgd2UgdHJ5IHRoaXM/CgpGcm9tOiBB cmNoaXQgVGFuZWphIDxhcmNoaXR0QGNvZGVhdXJvcmEub3JnPgpEYXRlOiBNb24sIDE0IFNlcCAy MDE1IDIwOjExOjQzICswNTMwClN1YmplY3Q6IFtQQVRDSF0gZHJtL21nYWcyMDA6IFByZXZlbnQg Y2FsbGluZyBkcm1fZmJfaGVscGVyX2ZpbmkgdHdpY2UKCm1nYWcyMDBfZmJkZXZfaW5pdCdzIGVy cm9yIGhhbmRsaW5nIHBhdGggY2FsbHMgZHJtX2ZiX2hlbHBlcl9maW5pIGJlZm9yZQpiYWlsaW5n IG91dC4gVGhlIGVycm9yIGhhbmRsaW5nIHBhdGggb2YgbWdhZzIwMF9kcml2ZXJfbG9hZCBhbHNv IGVuZHMKdXAgY2FsbGluZyBkcm1fZmJfaGVscGVyX2ZpbmkuCgpUaGlzIHJlc3VsdHMgaW4gZHJt X2ZiX2hlbHBlcl9maW5pIGJlaW5nIGNhbGxlZCB0d2ljZSBpZiB0aGUgZHJpdmVyIGxvYWQKZHJt IG9wIGZhaWxzIHNvbWV3aGVyZSBpbiBiZXR3ZWVuLgoKTWFrZSBvbmx5IG1nYWcyMDBfZHJpdmVy X3VubG9hZCBjYWxsIGRybV9mYl9oZWxwZXJfZmluaSwgcmVtb3ZlIHRoZSBjYWxsCmZyb20gbWdh ZzIwMF9mYmRldl9pbml0LgoKU2lnbmVkLW9mZi1ieTogQXJjaGl0IFRhbmVqYSA8YXJjaGl0dEBj b2RlYXVyb3JhLm9yZz4KLS0tCiAgZHJpdmVycy9ncHUvZHJtL21nYWcyMDAvbWdhZzIwMF9mYi5j IHwgOCArKy0tLS0tLQogIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDYgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21nYWcyMDAvbWdhZzIwMF9mYi5j IApiL2RyaXZlcnMvZ3B1L2RybS9tZ2FnMjAwL21nYWcyMDBfZmIuYwppbmRleCA4N2RlMTVlLi42 MjU5YjBhIDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vbWdhZzIwMC9tZ2FnMjAwX2ZiLmMK KysrIGIvZHJpdmVycy9ncHUvZHJtL21nYWcyMDAvbWdhZzIwMF9mYi5jCkBAIC0yODAsMjAgKzI4 MCwxNiBAQCBpbnQgbWdhZzIwMF9mYmRldl9pbml0KHN0cnVjdCBtZ2FfZGV2aWNlICptZGV2KQoK ICAJcmV0ID0gZHJtX2ZiX2hlbHBlcl9zaW5nbGVfYWRkX2FsbF9jb25uZWN0b3JzKCZtZmJkZXYt PmhlbHBlcik7CiAgCWlmIChyZXQpCi0JCWdvdG8gZmluaTsKKwkJcmV0dXJuIHJldDsKCiAgCS8q IGRpc2FibGUgYWxsIHRoZSBwb3NzaWJsZSBvdXRwdXRzL2NydGNzIGJlZm9yZSBlbnRlcmluZyBL TVMgbW9kZSAqLwogIAlkcm1faGVscGVyX2Rpc2FibGVfdW51c2VkX2Z1bmN0aW9ucyhtZGV2LT5k ZXYpOwoKICAJcmV0ID0gZHJtX2ZiX2hlbHBlcl9pbml0aWFsX2NvbmZpZygmbWZiZGV2LT5oZWxw ZXIsIGJwcF9zZWwpOwogIAlpZiAocmV0KQotCQlnb3RvIGZpbmk7CisJCXJldHVybiByZXQ7Cgog IAlyZXR1cm4gMDsKLQotZmluaToKLQlkcm1fZmJfaGVscGVyX2ZpbmkoJm1mYmRldi0+aGVscGVy KTsKLQlyZXR1cm4gcmV0OwogIH0KCiAgdm9pZCBtZ2FnMjAwX2ZiZGV2X2Zpbmkoc3RydWN0IG1n YV9kZXZpY2UgKm1kZXYpCgoKCi0tIApRdWFsY29tbSBJbm5vdmF0aW9uIENlbnRlciwgSW5jLiBp cyBhIG1lbWJlciBvZiBDb2RlIEF1cm9yYSBGb3J1bSwKYSBMaW51eCBGb3VuZGF0aW9uIENvbGxh Ym9yYXRpdmUgUHJvamVjdApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo=