Re: [PATCH 12/31] drm/amdgpu: use kmemdup rather than duplicating its implementation

From: Andrzej Hajda <a.hajda@samsung.com>
To: "Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@linux.ie>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 12/31] drm/amdgpu: use kmemdup rather than duplicating its implementation
Date: Wed, 16 Sep 2015 11:56:43 +0200	[thread overview]
Message-ID: <55F93CDB.70505@samsung.com> (raw)
In-Reply-To: <1438934377-4922-13-git-send-email-a.hajda@samsung.com>

Ping.

Regards
Andrzej

On 08/07/2015 09:59 AM, Andrzej Hajda wrote:
> The patch was generated using fixed coccinelle semantic patch
> scripts/coccinelle/api/memdup.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 8da6424..94bd992 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -549,12 +549,10 @@ int amdgpu_bo_set_metadata (struct amdgpu_bo *bo, void *metadata,
>  	if (metadata == NULL)
>  		return -EINVAL;
>  
> -	buffer = kzalloc(metadata_size, GFP_KERNEL);
> +	buffer = kmemdup(metadata, metadata_size, GFP_KERNEL);
>  	if (buffer == NULL)
>  		return -ENOMEM;
>  
> -	memcpy(buffer, metadata, metadata_size);
> -
>  	kfree(bo->metadata);
>  	bo->metadata_flags = flags;
>  	bo->metadata = buffer;

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel