From: poma <pomidorabelisima@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Dave Airlie <airlied@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/udl: Fix for the X server screen update v2
Date: Thu, 22 Sep 2016 14:23:44 +0200 [thread overview]
Message-ID: <55a2699f-c6a5-ab2c-2fdf-a1afc4d050da@gmail.com> (raw)
In-Reply-To: <CAKMK7uHExDBisQqceFS+XFtX9UG_jCOqACU2H2bN1-=ui4tc2g@mail.gmail.com>
On 19.09.2016 23:12, Daniel Vetter wrote:
> On Mon, Sep 19, 2016 at 8:27 PM, poma <pomidorabelisima@gmail.com> wrote:
>> @@ -122,14 +126,14 @@ int udl_handle_damage(struct udl_framebuffer *fb, int x, int y,
>> return 0;
>> cmd = urb->transfer_buffer;
>>
>> - for (i = y; i < height ; i++) {
>> + for (i = y; i <= y2 ; i++) {
>
> I think a simpler fix (which retains Noralf's nice cleanup would be to
> change the loop condition to i < y + height. At least that seems to be
> the underlying bug. Can you pls test that and then submit either that
> one-liner (if it works) or your original patch (it's missing the
> signed-off-by right now, so can't be merged as-is)? Either one has my
> r-b (preemptive since I'm travelling).
>
> Thanks, Daniel
>
Feel free to (re)send patch v3, whenever you can.
After all, the idea is yours.
Respect
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-09-22 13:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 14:44 UDL: screen update breakage poma
2016-09-18 10:20 ` Noralf Trønnes
2016-09-18 13:48 ` [PATCH] drm/udl: Fix for the X server screen update poma
2016-09-18 17:42 ` Noralf Trønnes
2016-09-19 6:41 ` poma
2016-09-19 18:27 ` [PATCH] drm/udl: Fix for the X server screen update v2 poma
2016-09-19 21:12 ` Daniel Vetter
2016-09-21 4:47 ` [PATCH] drm/udl: Fix for the X server screen update v3 poma
2016-09-21 7:34 ` David Herrmann
2016-09-21 11:19 ` poma
2016-09-21 11:33 ` David Herrmann
2016-09-21 14:57 ` poma
2016-09-21 18:51 ` Jani Nikula
2016-09-21 11:35 ` Jani Nikula
2016-09-22 12:23 ` poma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55a2699f-c6a5-ab2c-2fdf-a1afc4d050da@gmail.com \
--to=pomidorabelisima@gmail.com \
--cc=airlied@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).