From: Deepak Singh Rawat <drawat@vmware.com>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: david@lechnology.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/4] drm/tinydrm: Use damage helper for dirtyfb
Date: Thu, 10 Jan 2019 09:22:27 -0800 [thread overview]
Message-ID: <55d2f558dcba384f1f7028fc7878dba9ebae11a4.camel@vmware.com> (raw)
In-Reply-To: <20190109174956.43052-1-noralf@tronnes.org>
On Wed, 2019-01-09 at 18:49 +0100, Noralf Trønnes wrote:
> Hi,
>
> I was really pleased to see that the damage helper had landed. Now I
> can
> do framebuffer flushing solely through the display pipe functions.
> This
> prepares the ground for the removal of struct tinydrm_device in my
> next
> series.
Hi Noralf,
Not an expert of tinydrm but I followed the code and everything looked
alright to me especially the usage of damage iterator.
Yes the code to clear damage on plane state destroy was missing earlier
and can be removed from the new helper you have. It is better to have
damage in plane state as something else might need it.
Thanks,
Deepak
>
> Note:
> The damage helper isn't in drm-misc-next yet, it will show up when
> -rc1
> arrives there.
>
> Noralf.
>
> Noralf Trønnes (4):
> drm/gem-fb-helper: Add drm_gem_fb_create_with_dirty()
> drm/damage-helper: Add drm_atomic_helper_damage_merged()
> drm/tinydrm: Use struct drm_rect
> drm/tinydrm: Use damage helper for dirtyfb
>
> drivers/gpu/drm/drm_damage_helper.c | 43 ++++++
> drivers/gpu/drm/drm_gem_framebuffer_helper.c | 47 +++++-
> drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 21 +--
> .../gpu/drm/tinydrm/core/tinydrm-helpers.c | 100 +------------
> drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 30 ----
> drivers/gpu/drm/tinydrm/hx8357d.c | 2 +-
> drivers/gpu/drm/tinydrm/ili9225.c | 138 +++++++---------
> --
> drivers/gpu/drm/tinydrm/ili9341.c | 2 +-
> drivers/gpu/drm/tinydrm/mi0283qt.c | 2 +-
> drivers/gpu/drm/tinydrm/mipi-dbi.c | 87 +++++++----
> drivers/gpu/drm/tinydrm/repaper.c | 42 +++---
> drivers/gpu/drm/tinydrm/st7586.c | 73 ++++-----
> drivers/gpu/drm/tinydrm/st7735r.c | 2 +-
> include/drm/drm_damage_helper.h | 3 +
> include/drm/drm_gem_framebuffer_helper.h | 3 +
> include/drm/tinydrm/mipi-dbi.h | 5 +-
> include/drm/tinydrm/tinydrm-helpers.h | 20 +--
> include/drm/tinydrm/tinydrm.h | 26 ----
> 18 files changed, 281 insertions(+), 365 deletions(-)
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-01-10 17:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 17:49 [PATCH 0/4] drm/tinydrm: Use damage helper for dirtyfb Noralf Trønnes
2019-01-09 17:49 ` [PATCH 1/4] drm/gem-fb-helper: Add drm_gem_fb_create_with_dirty() Noralf Trønnes
2019-01-09 20:46 ` Daniel Vetter
2019-01-09 17:49 ` [PATCH 2/4] drm/damage-helper: Add drm_atomic_helper_damage_merged() Noralf Trønnes
2019-01-10 13:04 ` Noralf Trønnes
2019-01-09 17:49 ` [PATCH 3/4] drm/tinydrm: Use struct drm_rect Noralf Trønnes
2019-01-09 17:49 ` [PATCH 4/4] drm/tinydrm: Use damage helper for dirtyfb Noralf Trønnes
2019-01-11 1:06 ` David Lechner
2019-01-11 16:16 ` Noralf Trønnes
2019-01-11 19:18 ` kbuild test robot
2019-01-09 18:26 ` [PATCH 0/4] " Sam Ravnborg
2019-01-09 18:59 ` Noralf Trønnes
2019-01-09 20:49 ` Daniel Vetter
2019-01-10 17:22 ` Deepak Singh Rawat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55d2f558dcba384f1f7028fc7878dba9ebae11a4.camel@vmware.com \
--to=drawat@vmware.com \
--cc=david@lechnology.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=noralf@tronnes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox