From: Vincent ABRIOU <vincent.abriou@st.com>
To: "ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Cc: Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH 2/2] drm: s/int pipe/unsigned int pipe/
Date: Fri, 2 Oct 2015 15:07:50 +0200 [thread overview]
Message-ID: <560E81A6.60803@st.com> (raw)
In-Reply-To: <1443620809-28329-2-git-send-email-ville.syrjala@linux.intel.com>
Hi,
On 09/30/2015 03:46 PM, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Make the 'pipe' argument to drm_vblank_count() unsigned as it is
> everwhere else.
>
> Cc: Vincent Abriou <vincent.abriou@st.com>
> Cc: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/drm_irq.c | 2 +-
> include/drm/drmP.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
> index 7d70b7c..f24c57c 100644
> --- a/drivers/gpu/drm/drm_irq.c
> +++ b/drivers/gpu/drm/drm_irq.c
> @@ -876,7 +876,7 @@ drm_get_last_vbltimestamp(struct drm_device *dev, unsigned int pipe,
> * Returns:
> * The software vblank counter.
> */
> -u32 drm_vblank_count(struct drm_device *dev, int pipe)
> +u32 drm_vblank_count(struct drm_device *dev, unsigned int pipe)
> {
> struct drm_vblank_crtc *vblank = &dev->vblank[pipe];
>
> diff --git a/include/drm/drmP.h b/include/drm/drmP.h
> index f563333..8df4de7 100644
> --- a/include/drm/drmP.h
> +++ b/include/drm/drmP.h
> @@ -928,7 +928,7 @@ extern int drm_irq_uninstall(struct drm_device *dev);
> extern int drm_vblank_init(struct drm_device *dev, unsigned int num_crtcs);
> extern int drm_wait_vblank(struct drm_device *dev, void *data,
> struct drm_file *filp);
> -extern u32 drm_vblank_count(struct drm_device *dev, int pipe);
> +extern u32 drm_vblank_count(struct drm_device *dev, unsigned int pipe);
> extern u32 drm_crtc_vblank_count(struct drm_crtc *crtc);
> extern u32 drm_vblank_count_and_time(struct drm_device *dev, unsigned int pipe,
> struct timeval *vblanktime);
>
If you update drm_vblank_count you also need to update
drm_vblank_no_hw_counter and need to change the u32
(*get_vblank_counter) prototype.
Thierry already done the job with "drm/irq: Use unsigned int pipe in
public API" patch
BR
Vincent
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-10-02 13:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 13:46 [PATCH 1/2] drm: Stop using drm_vblank_count() as the hw frame counter ville.syrjala
2015-09-30 13:46 ` [PATCH 2/2] drm: s/int pipe/unsigned int pipe/ ville.syrjala
2015-10-02 13:07 ` Vincent ABRIOU [this message]
2015-10-02 13:12 ` Ville Syrjälä
2015-10-02 13:22 ` Vincent ABRIOU
2015-10-02 15:39 ` Ville Syrjälä
2015-10-07 13:12 ` Vincent ABRIOU
2015-10-06 9:36 ` Thierry Reding
2015-09-30 14:08 ` [PATCH 1/2] drm: Stop using drm_vblank_count() as the hw frame counter Daniel Vetter
2015-09-30 14:14 ` Ville Syrjälä
2015-09-30 14:44 ` Vincent ABRIOU
2015-10-01 9:10 ` Vincent ABRIOU
2015-10-01 15:25 ` Rob Clark
2015-10-01 15:44 ` Ville Syrjälä
2015-10-01 15:47 ` Ville Syrjälä
2015-10-01 15:56 ` Rob Clark
2015-10-02 8:25 ` Vincent ABRIOU
2015-10-02 12:48 ` Ville Syrjälä
2015-10-02 13:03 ` Vincent ABRIOU
2015-10-07 12:54 ` Vincent ABRIOU
2015-10-07 14:14 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560E81A6.60803@st.com \
--to=vincent.abriou@st.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=treding@nvidia.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox