From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: David Airlie <airlied@linux.ie>,
Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Andy Yan <andy.yan@rock-chips.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/3] drm: dw_hdmi: use of_get_i2c_adapter_by_node interface
Date: Mon, 12 Oct 2015 16:14:01 +0300 [thread overview]
Message-ID: <561BB219.9040405@mentor.com> (raw)
In-Reply-To: <1442958492-6618-1-git-send-email-vladimir_zapolskiy@mentor.com>
David, Russel,
ping.
On 23.09.2015 00:48, Vladimir Zapolskiy wrote:
> This change is needed to properly lock I2C bus driver, which serves DDC.
>
> The change fixes an overflow over zero of I2C bus driver user counter:
>
> root@mx6q:~# lsmod | grep i2c
> i2c_imx 15348 0
> root@mx6q:~# lsmod | grep dw_hdmi_imx
> dw_hdmi_imx 3567 0
> dw_hdmi 15850 1 dw_hdmi_imx
> imxdrm 8610 3 dw_hdmi_imx,imx_ipuv3_crtc,imx_ldb
> root@mx6q:~# rmmod dw_hdmi_imx
> root@mx6q:~# lsmod | grep i2c
> i2c_imx 15348 -1
>
> ^^^^^
>
> root@mx6q:~# rmmod i2c_imx
> rmmod: ERROR: Module i2c_imx is in use
>
> Note that prior to this change put_device() coupled with
> of_find_i2c_adapter_by_node() was missing on error path of
> dw_hdmi_bind(), added i2c_put_adapter() there along with the change.
>
> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Andy Yan <andy.yan@rock-chips.com>
--
With best wishes,
Vladimir
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-10-12 13:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 21:46 [PATCH v2 0/3] drm: fix i2c adapter device driver user counter Vladimir Zapolskiy
2015-09-22 21:48 ` [PATCH v2 1/3] drm: dw_hdmi: use of_get_i2c_adapter_by_node interface Vladimir Zapolskiy
2015-10-12 13:14 ` Vladimir Zapolskiy [this message]
2015-09-22 21:48 ` [PATCH v2 2/3] drm: tilcdc: " Vladimir Zapolskiy
2015-09-22 21:48 ` [PATCH v2 3/3] drm: tegra: " Vladimir Zapolskiy
2015-10-12 13:15 ` [PATCH v2 0/3] drm: fix i2c adapter device driver user counter Vladimir Zapolskiy
2015-11-02 15:10 ` Vladimir Zapolskiy
2015-11-30 14:19 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561BB219.9040405@mentor.com \
--to=vladimir_zapolskiy@mentor.com \
--cc=airlied@linux.ie \
--cc=andy.yan@rock-chips.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox