From: "Michel Dänzer" <michel@daenzer.net>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Michael Burian <michael.burian@sbg.at>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: No backlight since linux-4.2.4 - drivers/gpu/drm/radeon/atombios_encoders.c
Date: Thu, 29 Oct 2015 12:18:28 +0900 [thread overview]
Message-ID: <56319004.7090002@daenzer.net> (raw)
In-Reply-To: <CADnq5_OL4bumk0OgoqCJQ+LMfbrJt3hQD98r7qWz=cuSpz991g@mail.gmail.com>
On 29.10.2015 04:03, Alex Deucher wrote:
> On Wed, Oct 28, 2015 at 3:11 AM, Michel Dänzer <michel@daenzer.net> wrote:
>> On 28.10.2015 01:43, Alex Deucher wrote:
>>> On Tue, Oct 27, 2015 at 12:23 PM, Michael Burian <michael.burian@sbg.at> wrote:
>>>> On 10/27/15 16:10, Alex Deucher wrote:
>>>>
>>>>>
>>>>> It would appear that your system does not use the gpu backlight
>>>>> controller. Either it's lying or messing with the GPU backlight
>>>>> controller causes some bad interaction with whatever does control it.
>>>>> Does the attached radeon patch help? I'm also attaching an amdgpu
>>>>> patch for reference in case the same problem appears on amdgpu.
>>>>>
>>>>
>>>> no, still no backlight when applied against current current mainline
>>>>
>>>> 858e904bd71dd0057a548d6785d94ce5ec4aeabd (Merge tag 'iommu-fixes-v4.3-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu)
>>>>
>>>
>>> I see the problem. We don't enable native backlight control on older
>>> asics like yours by default. Does the attached patch help?
>>
>> My only doubt about this patch is: Should we also fall back to the old
>> beahviour in the !(rdev->mode_info.firmware_flags &
>> ATOM_BIOS_INFO_BL_CONTROLLED_BY_GPU) case?
>
> Theoretically, it's not necessary, but I guess better safe than sorry.
> Updated patches attached.
Both patches are
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
Apologies for the regression, and thanks for the fixes Alex!
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-10-29 3:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <562BDB47.5000301@sbg.at>
2015-10-26 9:32 ` No backlight since linux-4.2.4 - drivers/gpu/drm/radeon/atombios_encoders.c Michel Dänzer
2015-10-26 21:21 ` Alex Deucher
[not found] ` <562E0473.5060404@sbg.at>
2015-10-27 2:36 ` Michel Dänzer
2015-10-27 8:44 ` Michael Burian
2015-10-27 9:17 ` Michel Dänzer
2015-10-27 10:06 ` Michael Burian
2015-10-27 15:10 ` Alex Deucher
2015-10-27 16:23 ` Michael Burian
2015-10-27 16:43 ` Alex Deucher
2015-10-27 17:02 ` Michael Burian
2015-10-28 7:11 ` Michel Dänzer
2015-10-28 19:03 ` Alex Deucher
2015-10-28 20:46 ` Michael Burian
2015-10-29 3:18 ` Michel Dänzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56319004.7090002@daenzer.net \
--to=michel@daenzer.net \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=michael.burian@sbg.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox