From: Darren Hart <dvhart@linux.intel.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/1] apple-gmux: Assign apple_gmux_data before registering
Date: Mon, 16 Nov 2015 11:21:02 -0800 [thread overview]
Message-ID: <564A2C9E.5040104@linux.intel.com> (raw)
In-Reply-To: <cover.1447097319.git.lukas@wunner.de>
Hi Lukas,
Please send the patch to the list and maintainers reported by
get_maintainer.pl (specifically the platform-driver-x86 list and my
infradead ID) so we can have the review on list.
Thanks,
On 11/9/15 11:28 AM, Lukas Wunner wrote:
> Hi Darren,
>
> the following patch is a useful fix for apple-gmux by Matthew Garrett
> which is well over a year old but unfortunately never got merged.
>
> The commit message makes it sound as if the fix is only needed for
> reprobing (in case apple-gmux registers after the DRM drivers).
> I'm not yet sure if we'll use reprobing or deferred initialization,
> however the patch is needed even if we go with deferred initialization
> as it fixes a race condition that is triggered by invoking a handler
> callback between the call to vga_switcheroo_register_handler() and the
> assignment of apple_gmux_data.
>
> The patch has seen extensive testing and is actively used by myself
> and others on various MacBook Pro models.
>
> Could you take a look at the patch and (barring any objections) ack it?
>
> Thanks,
>
> Lukas
>
>
> Matthew Garrett (1):
> apple-gmux: Assign apple_gmux_data before registering
>
> drivers/platform/x86/apple-gmux.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
--
Darren Hart
Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-11-16 19:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 19:28 [PATCH 0/1] apple-gmux: Assign apple_gmux_data before registering Lukas Wunner
2014-03-05 22:34 ` [PATCH 1/1] " Lukas Wunner
2015-11-23 19:17 ` Darren Hart
2015-11-16 19:21 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564A2C9E.5040104@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lukas@wunner.de \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox