From: Andrzej Hajda <a.hajda@samsung.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: linux-samsung-soc@vger.kernel.org,
dri-devel@lists.freedesktop.org, tjakobi@math.uni-bielefeld.de,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
"Szyprowski, Marek" <m.szyprowski@samsung.com>
Subject: Re: [PATCH] drm/exynos: only run atomic_check() if crtc is active
Date: Fri, 20 Nov 2015 10:15:10 +0100 [thread overview]
Message-ID: <564EE49E.1030308@samsung.com> (raw)
In-Reply-To: <20151117161239.GI16848@phenom.ffwll.local>
On 11/17/2015 05:12 PM, Daniel Vetter wrote:
(...)
>
> Check crtc_state->enable, skip if false. That's the "is this pipeline
> configured" knob. For plane/connector it's state->crtc, but with the same
> role.
>
> I guess we could check that in the helpers, but we need to be careful to
> still call ->atomic_check for the disabling transition, in case userspace
> is asking for a vblank-synced flip that disables a plane but somehow
> that's not possible. I somewhat prefer to handle that all in drivers
> though.
> -Daniel
>
Thanks for the explanation, Gustavo will you update your patch?
Regards
Andrzej
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-11-20 9:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 13:11 [PATCH] drm/exynos: only run atomic_check() if crtc is active Gustavo Padovan
2015-11-12 13:49 ` Thierry Reding
2015-11-17 10:06 ` Daniel Vetter
2015-11-17 14:19 ` Andrzej Hajda
2015-11-17 16:12 ` Daniel Vetter
2015-11-20 9:15 ` Andrzej Hajda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564EE49E.1030308@samsung.com \
--to=a.hajda@samsung.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox