Re: [PATCH 3/3] dt-bindings: exynos-dp: update ports node binding for panel

From: Inki Dae <inki.dae@samsung.com>
To: Rob Herring <robh@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	k.kozlowski@samsung.com, linux-samsung-soc@vger.kernel.org,
	pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
	dri-devel@lists.freedesktop.org, javier@osg.samsung.com,
	kgene.kim@samsung.com, galak@codeaurora.org
Subject: Re: [PATCH 3/3] dt-bindings: exynos-dp: update ports node binding for panel
Date: Fri, 04 Dec 2015 18:08:47 +0900	[thread overview]
Message-ID: <5661581F.8040505@samsung.com> (raw)
In-Reply-To: <20151203233853.GA8608@rob-hp-laptop>

Hi Rob,

2015년 12월 04일 08:38에 Rob Herring 이(가) 쓴 글:
> On Thu, Dec 03, 2015 at 06:30:10PM +0900, Inki Dae wrote:
>> This patch updates a ports node binding for panel.
>>
>> With this, dp node can have a ports node which describes
>> a remote endpoint node that can be connected to panel or bridge
>> node.
>>
>> Signed-off-by: Inki Dae <inki.dae@samsung.com>
>> ---
>>  .../bindings/display/exynos/exynos_dp.txt          | 28 ++++++++++++++++++----
>>  1 file changed, 24 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt b/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt
>> index 64693f2..15b52cb 100644
>> --- a/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt
>> +++ b/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt
>> @@ -66,8 +66,15 @@ Optional properties for dp-controller:
>>  		Hotplug detect GPIO.
>>  			Indicates which GPIO should be used for hotplug
>>  			detection
>> -	-video interfaces: Device node can contain video interface port
>> -			    nodes according to [1].
>> +Video interfaces:
>> +  Device node can contain video interface port nodes according to [1].
>> +  The following are properties specific to those nodes:
>> +
>> +  endpoint node connected to bridge or panel node:
>> +   - remote-endpoint: specifies the endpoint in panel or bridge node.
>> +		      This node is required in all kinds of exynos dp
>> +		      to represent the connection between dp and bridge
>> +		      ,or dp and panel.
> 
> Fix your punctuation.

Right. 

> 
>>  
>>  [1]: Documentation/devicetree/bindings/media/video-interfaces.txt
>>  
>> @@ -111,9 +118,22 @@ Board Specific portion:
>>  		};
>>  
>>  		ports {
>> -			port@0 {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
> 
> You don't need these.

Ditto.

> 
>> +
>> +			port {
>>  				dp_out: endpoint {
>> -					remote-endpoint = <&bridge_in>;
>> +					remote-endpoint = <&dp_in>;
>> +				};
>> +			};
>> +		};
>> +
>> +		panel@0 {
>> +			reg = <0>;
> 
> Drop the @0 and reg as you only have 1.

Ditto.

Thanks,
Inki Dae

> 
>> +			...
>> +			port {
>> +				dp_in: endpoint {
>> +					remote-endpoint = <&dp_out>;
>>  				};
>>  			};
>>  		};
>> -- 
>> 1.9.1
>>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel