From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
Inki Dae <inki.dae@samsung.com>,
dri-devel@lists.freedesktop.org
Cc: airlied@linux.ie, devicetree@vger.kernel.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com
Subject: Re: [PATCH 4/4] ARM: dts: Use OF graph for DP to panel connection in exynos5800-peach-pi
Date: Tue, 08 Dec 2015 10:47:16 +0900 [thread overview]
Message-ID: <566636A4.1050908@samsung.com> (raw)
In-Reply-To: <56663384.8060708@osg.samsung.com>
On 08.12.2015 10:33, Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On 12/07/2015 09:45 PM, Krzysztof Kozlowski wrote:
>> On 07.12.2015 21:52, Inki Dae wrote:
>>> From: Javier Martinez Canillas <javier@osg.samsung.com>
>>>
>>> The DT binding for the Exynos DRM Display Port (DP) driver isn't consistent
>>> since it uses a phandle to describe the connection between the DP port and
>>> the display panel but uses the OF graph ports and endpoints to describe the
>>> connection betwen the DP port, a bridge chip and the panel.
>>>
>>> The Exynos DP driver and the DT binding have been changed to allow also to
>>> describe the DP port to panel connection using ports / endpoints (OF graph)
>>> so this patch changes the Exynos5800 Peach Pi DT to make it consistent with
>>> the Exynos5420 Peach Pit that has a eDP to LVDS chip and uses OF graph too.
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>> Tested-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>> Reviewed-by: Inki Dae <inki.dae@samsung.com>
>>> ---
>>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 15 ++++++++++++++-
>>> 1 file changed, 14 insertions(+), 1 deletion(-)
>>>
>>
>> Looks sensible:
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
>> Dependencies are not mentioned, does it depend on patch 1?
>>
>
> Yes, it depends on patch 1/4 so it should be merged through the Exynos DRM
> tree to maintain bisectability. Inki's patch maintains the DT ABI backward
> compatibility though so another option is to wait until the DRM change hit
> mainline and then pick $SUBJECT.
Thanks. We could also use a tag with DRM changes for samsung-soc but
since I already flushed my queue for v4.5 I think it would be an
overkill. From my point of view it can safely go through exynos-drm tree.
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-12-08 1:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 12:52 [PATCH v2 0/4] drm/exynos: dp: consider port node outbound for panel Inki Dae
2015-12-07 12:52 ` [PATCH v3 1/4] drm/exynos: dp: add of_graph dt binding support " Inki Dae
2015-12-07 12:52 ` [PATCH v2 2/4] drm/exynos: dp: fix wrong return type Inki Dae
2015-12-07 12:52 ` [PATCH v2 3/4] dt-bindings: exynos-dp: update ports node binding for panel Inki Dae
2015-12-08 15:29 ` Rob Herring
2015-12-07 12:52 ` [PATCH 4/4] ARM: dts: Use OF graph for DP to panel connection in exynos5800-peach-pi Inki Dae
2015-12-07 13:41 ` Javier Martinez Canillas
2015-12-07 15:36 ` Inki Dae
2015-12-08 0:48 ` Krzysztof Kozlowski
2015-12-08 1:44 ` Javier Martinez Canillas
2015-12-08 2:09 ` Inki Dae
2015-12-08 0:45 ` Krzysztof Kozlowski
2015-12-08 1:33 ` Javier Martinez Canillas
2015-12-08 1:47 ` Krzysztof Kozlowski [this message]
2015-12-08 2:13 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566636A4.1050908@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inki.dae@samsung.com \
--cc=javier@osg.samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox