From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mario Kleiner <mario.kleiner.de@gmail.com>
Subject: Re: [PATCH 5/6] drm: Prevent vblank counter jumps with timestamp
 based update method.
Date: Wed, 10 Feb 2016 19:36:40 +0100
Message-ID: <56BB8338.7000504@gmail.com>
References: <1454894009-15466-1-git-send-email-mario.kleiner.de@gmail.com>
 <1454894009-15466-6-git-send-email-mario.kleiner.de@gmail.com>
 <20160209100917.GP11240@phenom.ffwll.local> <56B9EF5A.6050902@gmail.com>
 <20160209141149.GP23290@intel.com>
 <20160209150347.GZ11240@phenom.ffwll.local> <56BB652A.1010107@gmail.com>
 <CAKMK7uH2svOHdwHpS-_nm5Kbe0Ac_xMk6TCcorp2d35FQJiQ8Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <stable-owner@vger.kernel.org>
In-Reply-To: <CAKMK7uH2svOHdwHpS-_nm5Kbe0Ac_xMk6TCcorp2d35FQJiQ8Q@mail.gmail.com>
Sender: stable-owner@vger.kernel.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>, dri-devel <dri-devel@lists.freedesktop.org>, linux@bernd-steinhauser.de, stable <stable@vger.kernel.org>, =?UTF-8?Q?Michel_D=c3=a4nzer?= <michel@daenzer.net>, Vlastimil Babka <vbabka@suse.cz>, "alexander.deucher@amd.com" <alexander.deucher@amd.com>, =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
List-Id: dri-devel@lists.freedesktop.org

On 02/10/2016 06:17 PM, Daniel Vetter wrote:
> On Wed, Feb 10, 2016 at 5:28 PM, Mario Kleiner
> <mario.kleiner.de@gmail.com> wrote:
>> There's another scenario where this zero-ts case can be hit. If the driver
>> drm_vblank_init()'s - setting all timestamps to zero - and then code starts
>> using vblanks (drm_vblank_get()) without drm_vblank_on beforehand, which is
>> afaics the case with nouveau. Unless that's considered an error as well,
>> we'd need to init the timestamps to something non-zero but harmless like 1
>> usecs at drm_vblank_init() time?
>
> Both legacy modeset helpers and atomic ones assume by default that you
> start out with everything disabled. Pre-atomic drivers make that
> happen by calling disable_unused_functions() to shut down anything the
> bios has enabled. I think this can't happen.
>
> For drivers that do take over bootloader display config they must call
> vblank_on explicitly themselves, which i915 does.
>
>> What makes sense as output here? DRM_WARN_ONCE?
>
> I'd go with WARN_ON and tune it down if it's offensive. But WARN_ON
> patch for 4.6 of course.
> -Daniel
>

Ok, so does this one have your R-b for stable as is? What about a proper 
nouveau fix if i find one? Probably also for 4.6 then, given that this 
patch fixes it up good enough for stable?

-mario