From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Skeggs Subject: Re: [PATCH 2/3] drm/nouveau: use post-decrement in error handling Date: Fri, 19 Feb 2016 13:32:55 +1000 Message-ID: <56C68CE7.30104@gmail.com> References: <1455561708-32390-1-git-send-email-linux@rasmusvillemoes.dk> <1455561708-32390-3-git-send-email-linux@rasmusvillemoes.dk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1143165446==" Return-path: Received: from mail-pf0-x22f.google.com (mail-pf0-x22f.google.com [IPv6:2607:f8b0:400e:c00::22f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 271DE6E400 for ; Fri, 19 Feb 2016 03:31:54 +0000 (UTC) Received: by mail-pf0-x22f.google.com with SMTP id x65so43207743pfb.1 for ; Thu, 18 Feb 2016 19:31:54 -0800 (PST) In-Reply-To: <1455561708-32390-3-git-send-email-linux@rasmusvillemoes.dk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rasmus Villemoes , David Airlie Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1143165446== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BKT82tm3mXhE877pPM93oSnhTc1hH4IH7" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BKT82tm3mXhE877pPM93oSnhTc1hH4IH7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/16/2016 04:41 AM, Rasmus Villemoes wrote: > We need to use post-decrement to get the dma_map_page undone also for > i=3D=3D0, and to avoid some very unpleasant behaviour if dma_map_page > failed already at i=3D=3D0. >=20 > Signed-off-by: Rasmus Villemoes Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nouveau_bo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nou= veau/nouveau_bo.c > index 78f520d05de9..e3acc35e3805 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_bo.c > +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > @@ -1520,7 +1520,7 @@ nouveau_ttm_tt_populate(struct ttm_tt *ttm) > DMA_BIDIRECTIONAL); > =20 > if (dma_mapping_error(pdev, addr)) { > - while (--i) { > + while (i--) { > dma_unmap_page(pdev, ttm_dma->dma_address[i], > PAGE_SIZE, DMA_BIDIRECTIONAL); > ttm_dma->dma_address[i] =3D 0; >=20 --BKT82tm3mXhE877pPM93oSnhTc1hH4IH7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWxoznAAoJEHYLnGJQkpH7o90P/RXmsfTwbLaKN0ChUQa07feO tmOAFCOiSFuRlodCSVmGjlCwezN4IagJz1oCPpYGqpZJ2ZbJ9cb6aFw7JMx3dYJ4 DX8/BWR6vZADgKoxOmBJkzSxtXoB0ElOut2BSepAmedN7/6/uEKyAWflfAoa0S3w Yw5AHdM/AocYrTN1mtHowo3hl1LJaptZ1j0gxYzqjTHdfDV+xKGg+6T0943ET+vz mHc68JmVyuJk0fOeOmSj/3kEJP8jlZpXOwMTpaH1MNAxEAidECWLQGuI5P4bWiqh Bz5IS0phSnRVnah2f+yNQ1ziAG/EOoXvOict+MIFt6bWk05hBVrEMnDv5Ie4M10t 0on8Q1QLryHHZS1CLFx8Z8dWcU5guUsSiQPT9n/+2jneQX3WhQHzTNLd0Vz7AsPO QZCiCwv4iR4kzPrRZvsJJHt0m/nneEd92BeXEoWZG6MbZo1JVPpsS+STNvkZLKuO KQksdOIZPHw+EPFN3tHRM57ru2PssylsTr7wu3dh1QCdbWko4nO4O52zhdGD14uU sv/mMDfVwhvhORJs2n5kmO1CsiLzGA5s8xNnu2uUyF1ELLMj0er0oaJiwzI+WS9B 12ZkwmlO+t/aquPjmkkzlbAlvPpztyo4HoSAKxY3CGZa09Sif44gGnuARBQi/hLm bbW5ausNU2ngTClynwk4 =sSvG -----END PGP SIGNATURE----- --BKT82tm3mXhE877pPM93oSnhTc1hH4IH7-- --===============1143165446== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1143165446==--