From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 18/33] drm/omap: increase vblank wait timeout Date: Wed, 24 Feb 2016 11:41:30 +0200 Message-ID: <56CD7ACA.2070706@ti.com> References: <1455875288-4370-1-git-send-email-tomi.valkeinen@ti.com> <1455875288-4370-19-git-send-email-tomi.valkeinen@ti.com> <2109780.mSKsi8MeiG@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0923692064==" Return-path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by gabe.freedesktop.org (Postfix) with ESMTPS id 76ABC89119 for ; Wed, 24 Feb 2016 13:49:38 +0000 (UTC) In-Reply-To: <2109780.mSKsi8MeiG@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0923692064== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d6xDA2S5L0ICAgbnIENJKrWrVXU2oPuSB" --d6xDA2S5L0ICAgbnIENJKrWrVXU2oPuSB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 24/02/16 00:43, Laurent Pinchart wrote: > Hi Tomi, >=20 > Thank you for the patch. >=20 > On Friday 19 February 2016 11:47:53 Tomi Valkeinen wrote: >> omap_crtc_wait_pending() waits until the config changes have been take= n >> into use, usually at next vblank. The wait-timeout used is 50ms, which= >> usually is enough, but in some rare cases not. >> >> As time wait-timeout is just a safety measure for cases where somethin= g >> is broken, we can just as well increase the timeout considerably. >=20 > Would it make sense to capture this in a comment in the code ? >=20 > Apart from that, >=20 > Acked-by: Laurent Pinchart I added a comment: /* * timeout is set to a "sufficiently" high value, which should cover * a single frame refresh even on slower displays. */ Tomi --d6xDA2S5L0ICAgbnIENJKrWrVXU2oPuSB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWzXrKAAoJEPo9qoy8lh71evUQAKblFAVQf9XzrsVSqb3y9QwZ faHcCP7XlxXg7HQofQmdY4PwM20WEcToIMHA95z8ZSYNji4DaWQJIuN3FTX5Z7fc m54x0UkGIeRqUm3OBFJOYJCjISfh07B+VIsvxx9KJd41xTrGGQXV6PQI+Qkc0a+g WTY0MY2o+O1+XID7LMyNQB58rZbFWhTBvUT36lIIQWr6zwNxTsW5hsmkg10E6uI0 s/GqX971UzwUFaNFT0/qjadZ0Txiaq2vy2i67O3dKAeZCjLBhNxBTR8lbDX5gj4l a0PYtnyBJ1Nwfet2XEu5ZJmJoyXa0b42GJeTdAOjwCRMOztazKraFtYJFvhlcjpD JWpFBJpJ69eMJqxBu9USDzivkBQNGgmdqkOagC/Hf97LOwVTh8rfHRYkVu8e4/e2 VVzIq4crNy5X3Ri5nsWOrpL6QY0QbZitlD5H+I7k+qIoXAhrk8ZX+RJbfnc84umZ 6qd2qgwHTkQsUWZGMURFRnWmcI6KzTpO1NoobRZgAPvBRk83sb/fX+7n/SEH8C1s a70XpBrMTWcwcn7Ne5cZ/kBYhTEcrewgqmbtx62Wcoqr0jCfy5xsZhZGpWdWZNh7 xHvcagV7HEcipphleOQosAcpoNl13tNKw/z2V4IW2M7QPmwFbdReih+tVDYSdldk Qc86Xh8XpLdTBGyp4NZr =b9vu -----END PGP SIGNATURE----- --d6xDA2S5L0ICAgbnIENJKrWrVXU2oPuSB-- --===============0923692064== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0923692064==--