From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Subject: Re: [PATCH] staging/android: refactor SYNC_IOC_FILE_INFO
Date: Mon, 29 Feb 2016 09:26:53 +0100
Message-ID: <56D400CD.6070804@linux.intel.com>
References: <1456511507-2534-4-git-send-email-gustavo@padovan.org>
 <1456520410-28195-1-git-send-email-gustavo@padovan.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id 61F176E20D
 for <dri-devel@lists.freedesktop.org>; Mon, 29 Feb 2016 08:26:58 +0000 (UTC)
In-Reply-To: <1456520410-28195-1-git-send-email-gustavo@padovan.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Gustavo Padovan <gustavo@padovan.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, Daniel Stone <daniels@collabora.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, Riley Andrews <riandrews@android.com>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= <arve@android.com>, Gustavo Padovan <gustavo.padovan@collabora.co.uk>, John Harrison <John.C.Harrison@Intel.com>
List-Id: dri-devel@lists.freedesktop.org

T3AgMjYtMDItMTYgb20gMjI6MDAgc2NocmVlZiBHdXN0YXZvIFBhZG92YW46Cj4gRnJvbTogR3Vz
dGF2byBQYWRvdmFuIDxndXN0YXZvLnBhZG92YW5AY29sbGFib3JhLmNvLnVrPgo+Cj4gQ2hhbmdl
IFNZTkNfSU9DX0ZJTEVfSU5GTyBiZWhhdmlvdXIgdG8gYXZvaWQgZnV0dXJlIEFQSSBicmVha3Mg
YW5kCj4gb3B0aW1pemUgYnVmZmVyIGFsbG9jYXRpb24uIEluIHRoZSBuZXcgYXBwcm9hY2ggdGhl
IGlvY3RsIG5lZWRzIHRvIGJlIGNhbGxlZAo+IHR3aWNlIHRvIHJldHJpZXZlIHRoZSBhcnJheSBv
ZiBmZW5jZV9pbmZvcyBwb2ludGVkIGJ5IGluZm8tPnN5bmNfZmVuY2VfaW5mby4KPgo+IFRoZSBm
aXJzdCBjYWxsIHNob3VsZCBwYXNzIG51bV9mZW5jZXMgPSAwLCB0aGUga2VybmVsIHdpbGwgdGhl
biBmaWxsCj4gaW5mby0+bnVtX2ZlbmNlcy4gVXNlcnNwYWNlIHJlY2VpdmVzIGJhY2sgdGhlIG51
bWJlciBvZiBmZW5jZXMgYW5kCj4gYWxsb2NhdGVzIGEgYnVmZmVyIHNpemUgbnVtX2ZlbmNlcyAq
IHNpemVvZihzdHJ1Y3Qgc3luY19mZW5jZV9pbmZvKSBvbgo+IGluZm8tPnN5bmNfZmVuY2VfaW5m
by4KPgo+IEl0IHRoZW4gY2FsbCB0aGUgaW9jdGwgYWdhaW4gcGFzc2luZyBudW1fZmVuY2VzIHJl
Y2VpdmVkIGluIGluZm8tPm51bV9mZW5jZXMuCj4gVGhlIGtlcm5lbCBjaGVja3MgaWYgaW5mby0+
bnVtX2ZlbmNlcyA+IDAgYW5kIGlmIHllcyBpdCBmaWxsCj4gaW5mby0+c3luY19mZW5jZV9pbmZv
IHdpdGggYW4gYXJyYXkgY29udGFpbmluZyBhbGwgZmVuY2VfaW5mb3MuCj4KPiBpbmZvLT5sZW4g
bm93IHJlcHJlc2VudHMgdGhlIGxlbmd0aCBvZiB0aGUgYnVmZmVyIHN5bmNfZmVuY2VfaW5mbyBw
b2ludHMKPiB0by4gQWxzbywgaW5mby0+c3luY19mZW5jZV9pbmZvIHdhcyBjb252ZXJ0ZWQgdG8g
X191NjQgcG9pbnRlci4KPgo+IEFuIGV4YW1wbGUgdXNlcnNwYWNlIGNvZGUgd291bGQgYmU6Cj4K
PiAJc3RydWN0IHN5bmNfZmlsZV9pbmZvICppbmZvOwo+IAlpbnQgZXJyLCBzaXplLCBudW1fZmVu
Y2VzOwo+Cj4gCWluZm8gPSBtYWxsb2Moc2l6ZW9mKCppbmZvKSk7Cj4KPiAJbWVtc2V0KGluZm8s
IDAsIHNpemVvZigqaW5mbykpOwo+Cj4gCWVyciA9IGlvY3RsKGZkLCBTWU5DX0lPQ19GSUxFX0lO
Rk8sIGluZm8pOwo+IAludW1fZmVuY2VzID0gaW5mby0+bnVtX2ZlbmNlczsKPgo+IAlpZiAobnVt
X2ZlbmNlcykgewo+IAkJbWVtc2V0KGluZm8sIDAsIHNpemVvZigqaW5mbykpOwpXb3VsZCB0aGlz
IG1lbXNldCBzdGlsbCBiZSBuZWVkZWQgaWYgd2UgZGlkbid0IGNoZWNrIGZvciBudWxscyBpbiBp
bmZvLT5zdGF0dXMgYW5kIGluZm8tPm5hbWUgPwoKU2VlbXMgdG8gbWUgdGhhdCBpdCBjb3VsZCBi
ZSBza2lwcGVkIGluIHRoYXQgY2FzZS4KPiAJCXNpemUgPSBzaXplb2Yoc3RydWN0IHN5bmNfZmVu
Y2VfaW5mbykgKiBudW1fZmVuY2VzOwo+IAkJaW5mby0+bGVuID0gc2l6ZTsKPiAJCWluZm8tPm51
bV9mZW5jZXMgPSBudW1fZmVuY2VzOwo+IAkJaW5mby0+c3luY19mZW5jZV9pbmZvID0gKHVpbnQ2
NF90KSBjYWxsb2MobnVtX2ZlbmNlcywKPiAJCQkJCQkJICBzaXplb2Yoc3RydWN0IHN5bmNfZmVu
Y2VfaW5mbykpOwo+Cj4gCQllcnIgPSBpb2N0bChmZCwgU1lOQ19JT0NfRklMRV9JTkZPLCBpbmZv
KTsKPiAJfQo+Cj4gdjI6IGZpeCBmZW5jZV9pbmZvIG1lbW9yeSBsZWFrCj4KPiBTaWduZWQtb2Zm
LWJ5OiBHdXN0YXZvIFBhZG92YW4gPGd1c3Rhdm8ucGFkb3ZhbkBjb2xsYWJvcmEuY28udWs+Cj4g
LS0tCj4gIGRyaXZlcnMvc3RhZ2luZy9hbmRyb2lkL3N5bmMuYyAgICAgIHwgNTIgKysrKysrKysr
KysrKysrKysrKysrKysrKysrKystLS0tLS0tLQo+ICBkcml2ZXJzL3N0YWdpbmcvYW5kcm9pZC91
YXBpL3N5bmMuaCB8ICA5ICsrKy0tLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCA0NSBpbnNlcnRpb25z
KCspLCAxNiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3N0YWdpbmcvYW5k
cm9pZC9zeW5jLmMgYi9kcml2ZXJzL3N0YWdpbmcvYW5kcm9pZC9zeW5jLmMKPiBpbmRleCBkYzVm
MzgyLi4yMzc5ZjIzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvc3RhZ2luZy9hbmRyb2lkL3N5bmMu
Ywo+ICsrKyBiL2RyaXZlcnMvc3RhZ2luZy9hbmRyb2lkL3N5bmMuYwo+IEBAIC01MDIsMjEgKzUw
MiwyMiBAQCBzdGF0aWMgaW50IHN5bmNfZmlsbF9mZW5jZV9pbmZvKHN0cnVjdCBmZW5jZSAqZmVu
Y2UsIHZvaWQgKmRhdGEsIGludCBzaXplKQo+ICBzdGF0aWMgbG9uZyBzeW5jX2ZpbGVfaW9jdGxf
ZmVuY2VfaW5mbyhzdHJ1Y3Qgc3luY19maWxlICpzeW5jX2ZpbGUsCj4gIAkJCQkJdW5zaWduZWQg
bG9uZyBhcmcpCj4gIHsKPiAtCXN0cnVjdCBzeW5jX2ZpbGVfaW5mbyAqaW5mbzsKPiArCXN0cnVj
dCBzeW5jX2ZpbGVfaW5mbyBpbiwgKmluZm87Cj4gKwlzdHJ1Y3Qgc3luY19mZW5jZV9pbmZvICpm
ZW5jZV9pbmZvID0gTlVMTDsKPiAgCV9fdTMyIHNpemU7Cj4gIAlfX3UzMiBsZW4gPSAwOwo9IDAg
dW5uZWVkZWQuCj4gIAlpbnQgcmV0LCBpOwo+ICAKPiAtCWlmIChjb3B5X2Zyb21fdXNlcigmc2l6
ZSwgKHZvaWQgX191c2VyICopYXJnLCBzaXplb2Yoc2l6ZSkpKQo+ICsJaWYgKGNvcHlfZnJvbV91
c2VyKCZpbiwgKHZvaWQgX191c2VyICopYXJnLCBzaXplb2YoKmluZm8pKSkKPiAgCQlyZXR1cm4g
LUVGQVVMVDsKPiAgCj4gLQlpZiAoc2l6ZSA8IHNpemVvZihzdHJ1Y3Qgc3luY19maWxlX2luZm8p
KQo+IC0JCXJldHVybiAtRUlOVkFMOwo+ICsJaWYgKGluLnN0YXR1cyB8fCBzdHJjbXAoaW4ubmFt
ZSwgIlwwIikpCj4gKwkJcmV0dXJuIC1FRkFVTFQ7ClRoZXNlIG1lbWJlcnMgYWx3YXlzIGdldCB3
cml0dGVuIGJ5IHRoZSBmZW5jZSBpb2N0bCwgSSdtIG5vdCBzdXJlIGl0IGFkZHMgdmFsdWUgdG8g
aGF2ZSB0aGVtIGV4cGxpY2l0bHkgemVybydkIG91dCBieSB1c2Vyc3BhY2UuCj4gLQlpZiAoc2l6
ZSA+IDQwOTYpCj4gLQkJc2l6ZSA9IDQwOTY7Cj4gKwlpZiAoaW4ubnVtX2ZlbmNlcyAmJiAhaW4u
c3luY19mZW5jZV9pbmZvKQo+ICsJCXJldHVybiAtRUZBVUxUOwpUaGlzIGNoZWNrIGlzIHVubmVl
ZGVkLCBpdCB3aWxsIGhhcHBlbiBpbiB0aGUgY29weV90b191c2VyIGNhbGwgYW55d2F5Lgo+IC0J
aW5mbyA9IGt6YWxsb2Moc2l6ZSwgR0ZQX0tFUk5FTCk7Cj4gKwlpbmZvID0ga3phbGxvYyhzaXpl
b2YoKmluZm8pLCBHRlBfS0VSTkVMKTsKPiAgCWlmICghaW5mbykKPiAgCQlyZXR1cm4gLUVOT01F
TTsKPiAgCj4gQEAgLTUyNSwxNCArNTI2LDMzIEBAIHN0YXRpYyBsb25nIHN5bmNfZmlsZV9pb2N0
bF9mZW5jZV9pbmZvKHN0cnVjdCBzeW5jX2ZpbGUgKnN5bmNfZmlsZSwKPiAgCWlmIChpbmZvLT5z
dGF0dXMgPj0gMCkKPiAgCQlpbmZvLT5zdGF0dXMgPSAhaW5mby0+c3RhdHVzOwo+ICAKPiAtCWlu
Zm8tPm51bV9mZW5jZXMgPSBzeW5jX2ZpbGUtPm51bV9mZW5jZXM7Cj4gKwkvKgo+ICsJICogUGFz
c2luZyBudW1fZmVuY2VzID0gMCBtZWFucyB0aGF0IHVzZXJzcGFjZSB3YW50IHRvIGtub3cgaG93
Cj4gKwkgKiBtYW55IGZlbmNlcyBhcmUgaW4gdGhlIHN5bmNfZmlsZSB0byBiZSBhYmxlIHRvIGFs
bG9jYXRlIGEgYnVmZmVyIHRvCj4gKwkgKiBmaXQgYWxsIHN5bmNfZmVuY2VfaW5mb3MgYW5kIGNh
bGwgdGhlIGlvY3RsIGFnYWluIHdpdGggdGhlIGJ1ZmZlcgo+ICsJICogYXNzaWduZWQgdG8gaW5m
by0+c3luY19mZW5jZV9pbmZvLiBUaGUgc2Vjb25kIGNhbGwgcGFzcyB0aGUKPiArCSAqIG51bV9m
ZW5jZXMgdmFsdWUgcmVjZWl2ZWQgaW4gdGhlIGZpcnN0IGNhbGwuCj4gKwkgKi8KPiArCWlmICgh
aW4ubnVtX2ZlbmNlcykKPiArCQlnb3RvIG5vX2ZlbmNlczsKPiArCj4gKwlzaXplID0gc3luY19m
aWxlLT5udW1fZmVuY2VzICogc2l6ZW9mKCpmZW5jZV9pbmZvKTsKPiArCWlmIChpbi5sZW4gIT0g
c2l6ZSkgewo+ICsJCXJldCA9IC1FRkFVTFQ7Cj4gKwkJZ290byBvdXQ7Cj4gKwl9Ck1heWJlIGNo
ZWNrIGZvciBpbi5sZW4gPCBzaXplLCBhbmQgc2V0IHNldCB0byBzaXplPwoKCj4gLQlsZW4gPSBz
aXplb2Yoc3RydWN0IHN5bmNfZmlsZV9pbmZvKTsKPiArCWZlbmNlX2luZm8gPSBremFsbG9jKHNp
emUsIEdGUF9LRVJORUwpOwo+ICsJaWYgKCFmZW5jZV9pbmZvKSB7Cj4gKwkJcmV0ID0gLUVOT01F
TTsKPiArCQlnb3RvIG91dDsKPiArCX0KPiAgCj4gIAlmb3IgKGkgPSAwOyBpIDwgc3luY19maWxl
LT5udW1fZmVuY2VzOyArK2kpIHsKPiAgCQlzdHJ1Y3QgZmVuY2UgKmZlbmNlID0gc3luY19maWxl
LT5jYnNbaV0uZmVuY2U7Cj4gIAo+IC0JCXJldCA9IHN5bmNfZmlsbF9mZW5jZV9pbmZvKGZlbmNl
LCAodTggKilpbmZvICsgbGVuLCBzaXplIC0gbGVuKTsKPiArCQlyZXQgPSBzeW5jX2ZpbGxfZmVu
Y2VfaW5mbyhmZW5jZSwgKHU4ICopZmVuY2VfaW5mbyArIGxlbiwKPiArCQkJCQkgICBzaXplIC0g
bGVuKTsKPiAgCj4gIAkJaWYgKHJldCA8IDApCj4gIAkJCWdvdG8gb3V0Owo+IEBAIC01NDAsMTQg
KzU2MCwyNCBAQCBzdGF0aWMgbG9uZyBzeW5jX2ZpbGVfaW9jdGxfZmVuY2VfaW5mbyhzdHJ1Y3Qg
c3luY19maWxlICpzeW5jX2ZpbGUsCj4gIAkJbGVuICs9IHJldDsKPiAgCX0KPiAgCj4gKwlpZiAo
Y29weV90b191c2VyKCh2b2lkIF9fdXNlciAqKWluLnN5bmNfZmVuY2VfaW5mbywgZmVuY2VfaW5m
bywgc2l6ZSkpIHsKPiArCQlyZXQgPSAtRUZBVUxUOwo+ICsJCWdvdG8gb3V0Owo+ICsJfQo+ICsK
PiAgCWluZm8tPmxlbiA9IGxlbjsKPiArCWluZm8tPnN5bmNfZmVuY2VfaW5mbyA9IChfX3U2NCkg
aW4uc3luY19mZW5jZV9pbmZvOwo+ICsKPiArbm9fZmVuY2VzOgo+ICsJaW5mby0+bnVtX2ZlbmNl
cyA9IHN5bmNfZmlsZS0+bnVtX2ZlbmNlczsKPiAgCj4gLQlpZiAoY29weV90b191c2VyKCh2b2lk
IF9fdXNlciAqKWFyZywgaW5mbywgbGVuKSkKPiArCWlmIChjb3B5X3RvX3VzZXIoKHZvaWQgX191
c2VyICopYXJnLCBpbmZvLCBzaXplb2YoKmluZm8pKSkKPiAgCQlyZXQgPSAtRUZBVUxUOwo+ICAJ
ZWxzZQo+ICAJCXJldCA9IDA7Cj4gIAo+ICBvdXQ6Cj4gKwlrZnJlZShmZW5jZV9pbmZvKTsKPiAg
CWtmcmVlKGluZm8pOwo+ICAKPiAgCXJldHVybiByZXQ7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv
c3RhZ2luZy9hbmRyb2lkL3VhcGkvc3luYy5oIGIvZHJpdmVycy9zdGFnaW5nL2FuZHJvaWQvdWFw
aS9zeW5jLmgKPiBpbmRleCBmMGI0MWNlLi45YWFkNjIzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv
c3RhZ2luZy9hbmRyb2lkL3VhcGkvc3luYy5oCj4gKysrIGIvZHJpdmVycy9zdGFnaW5nL2FuZHJv
aWQvdWFwaS9zeW5jLmgKPiBAQCAtNDIsMjEgKzQyLDIwIEBAIHN0cnVjdCBzeW5jX2ZlbmNlX2lu
Zm8gewo+ICAKPiAgLyoqCj4gICAqIHN0cnVjdCBzeW5jX2ZpbGVfaW5mbyAtIGRhdGEgcmV0dXJu
ZWQgZnJvbSBmZW5jZSBpbmZvIGlvY3RsCj4gLSAqIEBsZW46CWlvY3RsIGNhbGxlciB3cml0ZXMg
dGhlIHNpemUgb2YgdGhlIGJ1ZmZlciBpdHMgcGFzc2luZyBpbi4KPiAtICoJCWlvY3RsIHJldHVy
bnMgbGVuZ3RoIG9mIHN5bmNfZmlsZV9pbmZvIHJldHVybmVkIHRvCj4gLSAqCQl1c2Vyc3BhY2Ug
aW5jbHVkaW5nIHB0X2luZm8uCj4gICAqIEBuYW1lOgluYW1lIG9mIGZlbmNlCj4gICAqIEBzdGF0
dXM6CXN0YXR1cyBvZiBmZW5jZS4gMTogc2lnbmFsZWQgMDphY3RpdmUgPDA6ZXJyb3IKPiAgICog
QG51bV9mZW5jZXMJbnVtYmVyIG9mIGZlbmNlcyBpbiB0aGUgc3luY19maWxlCj4gKyAqIEBsZW46
CWlvY3RsIGNhbGxlciB3cml0ZXMgdGhlIHNpemUgb2YgdGhlIGJ1ZmZlciBpdHMgcGFzc2luZyBp
bi4KPiArICoJCWlvY3RsIHJldHVybnMgbGVuZ3RoIG9mIGFsbCBmZW5jZV9pbmZvcyBzdW1tZWQu
Cj4gICAqIEBzeW5jX2ZlbmNlX2luZm86IGFycmF5IG9mIHN5bmNfZmVuY2VfaW5mbyBmb3IgZXZl
cnkgZmVuY2UgaW4gdGhlIHN5bmNfZmlsZQo+ICAgKi8KPiAgc3RydWN0IHN5bmNfZmlsZV9pbmZv
IHsKPiAtCV9fdTMyCWxlbjsKPiAgCWNoYXIJbmFtZVszMl07Cj4gIAlfX3MzMglzdGF0dXM7Cj4g
IAlfX3UzMgludW1fZmVuY2VzOwo+ICsJX191MzIJbGVuOwo+ICAKPiAtCV9fdTgJc3luY19mZW5j
ZV9pbmZvWzBdOwo+ICsJX191NjQJc3luY19mZW5jZV9pbmZvOwo+ICB9Owo+ICAKPiAgI2RlZmlu
ZSBTWU5DX0lPQ19NQUdJQwkJJz4nCk5vdCBzdXJlIGlmIGxlbiBhZGRzIGFueXRoaW5nIGhlcmUs
IHVzZXJzcGFjZSBrbm93cyB0byBhbGxvY2F0ZSBudW1fZmVuY2VzICogc2l6ZW9mKHN0cnVjdCBz
eW5jX2ZlbmNlX2luZm8pOwoKSXQgY291bGQgcHJvYmFibHkgYmUgcmVtb3ZlZCBzaW5jZSBudW1f
ZmVuY2VzIHdvdWxkIGRvIHRoZSBzYW1lLgoKfk1hYXJ0ZW4KX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2
ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h
aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==