From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlos Palminha Subject: Re: [PATCH 01/16] drm: fixes crct set_mode when crtc mode_fixup is null. Date: Fri, 4 Mar 2016 10:14:48 +0000 Message-ID: <56D96018.4020701@synopsys.com> References: <9d41105dee6632b4bb50e9555f2196ac249b9fce.1455630967.git.palminha@synopsys.com> <20160216143733.GF32705@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160216143733.GF32705@phenom.ffwll.local> Sender: linux-renesas-soc-owner@vger.kernel.org To: Daniel Vetter Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, daniel.vetter@ffwll.ch, patrik.r.jakobsson@gmail.com, virtualization@lists.linux-foundation.org, jani.nikula@intel.com, sudipm.mukherjee@gmail.com, nicolas.pitre@linaro.org, linux-renesas-soc@vger.kernel.org, laurent.pinchart@ideasonboard.com, benjamin.gaignard@linaro.org, vincent.abriou@st.com, boris.brezillon@free-electrons.com, kraxel@redhat.com, jianwei.wang.chn@gmail.com, alison.wang@freescale.com List-Id: dri-devel@lists.freedesktop.org On 16-02-2016 14:37, Daniel Vetter wrote: > On Tue, Feb 16, 2016 at 02:10:03PM +0000, Carlos Palminha wrote: >> This patch set nukes all the dummy crtc mode_fixup implementations. >> (made on top of Daniel topic/drm-misc branch) >> >> Signed-off-by: Carlos Palminha > > Applied this one to drm-misc. I'll let the others hang out there for a bit > more to collect acks. It seems that we are not getting more ACKs. How can we push this forward? > > Thanks, Daniel > >> --- >> drivers/gpu/drm/drm_crtc_helper.c | 9 ++++++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c >> index e70d064..7539eea 100644 >> --- a/drivers/gpu/drm/drm_crtc_helper.c >> +++ b/drivers/gpu/drm/drm_crtc_helper.c >> @@ -343,9 +343,12 @@ bool drm_crtc_helper_set_mode(struct drm_crtc *crtc, >> } >> } >> >> - if (!(ret = crtc_funcs->mode_fixup(crtc, mode, adjusted_mode))) { >> - DRM_DEBUG_KMS("CRTC fixup failed\n"); >> - goto done; >> + if (crtc_funcs->mode_fixup) { >> + if (!(ret = crtc_funcs->mode_fixup(crtc, mode, >> + adjusted_mode))) { >> + DRM_DEBUG_KMS("CRTC fixup failed\n"); >> + goto done; >> + } >> } >> DRM_DEBUG_KMS("[CRTC:%d:%s]\n", crtc->base.id, crtc->name); >> >> -- >> 2.5.0 >> >