From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 07/42] drm/omap: connector-dvi: remove pdata support
Date: Mon, 7 Mar 2016 10:24:33 +0200 [thread overview]
Message-ID: <56DD3AC1.7070909@ti.com> (raw)
In-Reply-To: <17560528.XXHOdQNTlz@avalon>
[-- Attachment #1.1.1: Type: text/plain, Size: 578 bytes --]
On 07/03/16 10:16, Laurent Pinchart wrote:
>> @@ -319,17 +279,12 @@ static int dvic_probe(struct platform_device *pdev)
>>
>> platform_set_drvdata(pdev, ddata);
>>
>> - if (dev_get_platdata(&pdev->dev)) {
>> - r = dvic_probe_pdata(pdev);
>> - if (r)
>> - return r;
>> - } else if (pdev->dev.of_node) {
>> - r = dvic_probe_of(pdev);
>> - if (r)
>> - return r;
>> - } else {
>> + if (pdev->dev.of_node)
>
> I think you need to invert the condition.
Thanks! Well, I obviously wasn't too careful here... I'll go through all
of them.
Tomi
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-03-07 8:24 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 17:10 [PATCH 00/42] drm/omap: patches for v4.6 part 2 Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 01/42] drm/omap: fix suspend/resume handling Tomi Valkeinen
2016-03-07 7:52 ` Laurent Pinchart
2016-03-07 8:04 ` Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 02/42] drm/omap: move dss_suspend/resume_all to core.c Tomi Valkeinen
2016-03-07 7:53 ` Laurent Pinchart
2016-02-22 17:10 ` [PATCH 03/42] drm/omap: omapdss.h: remove unused struct omap_dss_hdmi_data Tomi Valkeinen
2016-03-07 7:55 ` Laurent Pinchart
2016-02-22 17:10 ` [PATCH 04/42] drm/omap: omapdss.h: remove omap_hdmi_init Tomi Valkeinen
2016-03-07 7:56 ` Laurent Pinchart
2016-02-22 17:10 ` [PATCH 05/42] drm/omap: panel-dsi-cm: remove pdata support Tomi Valkeinen
2016-03-07 8:04 ` Laurent Pinchart
2016-03-07 8:07 ` Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 06/42] drm/omap: encoder-tfp410: " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 07/42] drm/omap: connector-dvi: " Tomi Valkeinen
2016-03-07 8:16 ` Laurent Pinchart
2016-03-07 8:24 ` Tomi Valkeinen [this message]
2016-02-22 17:10 ` [PATCH 08/42] drm/omap: connector-hdmi: " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 09/42] drm/omap: panel-lgphilips-lb035q02: " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 10/42] drm/omap: panel-sharp-ls037v7dw01: " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 11/42] drm/omap: panel-nec-nl8048hl11: " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 12/42] drm/omap: panel-tpo-td028ttec1: " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 13/42] drm/omap: panel-tpo-td043mtea1: " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 14/42] drm/omap, omapfb: move exported dispc function declarations to omapdrm/omapfb Tomi Valkeinen
2016-03-07 8:42 ` Laurent Pinchart
2016-03-07 8:54 ` Tomi Valkeinen
2016-03-07 9:53 ` Laurent Pinchart
2016-02-22 17:10 ` [PATCH 15/42] drm/omap: move struct dss_mgr_ops " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 16/42] drm/omap: move dss_mgr_* declarations " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 17/42] drm/omap: Add dispc_mgr_get_supported_outputs() Tomi Valkeinen
2016-03-07 8:47 ` Laurent Pinchart
2016-03-07 9:08 ` Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 18/42] drm/omap: remove crtc->mgr field Tomi Valkeinen
2016-03-07 8:52 ` Laurent Pinchart
2016-03-07 9:19 ` Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 19/42] drm/omap: remove use of omapdss_find_mgr_from_display() Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 20/42] drm/omap: convert dss_mgr_ops to use omap_channel Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 21/42] drm/omap: add dispc_channel_connected field to omap_dss_device Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 22/42] drm/omap: use dispc_channel_connected in output drivers Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 23/42] drm/omap: convert dss_mgr_connect to accept omap_channel Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 24/42] drm/omap: convert dss_mgr_disconnect " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 25/42] drm/omap: convert dss_mgr_set_timings " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 26/42] drm/omap: convert dss_mgr_set_lcd_config " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 27/42] drm/omap: convert dss_mgr_enable " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 28/42] drm/omap: convert dss_mgr_disable " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 29/42] drm/omap: convert dss_mgr_start_update " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 30/42] drm/omap: convert dss_mgr_register_framedone_handler " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 31/42] drm/omap: convert dss_mgr_unregister_framedone_handler " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 32/42] drm/omap: remove extra check in dpi and sdi Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 33/42] drm/omap: remove extra manager checks on disconnect Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 34/42] drm/omap: DPI: remove uses of omap_overlay_manager Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 35/42] drm/omap: HDMI5: " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 36/42] drm/omap: HDMI4: " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 37/42] drm/omap: SDI: " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 38/42] drm/omap: VENC: " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 39/42] drm/omap: DSI: " Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 40/42] drm/omap: remove last " Tomi Valkeinen
2016-03-07 9:01 ` Laurent Pinchart
2016-03-07 9:10 ` Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 41/42] drm/omap: remove dss compat code Tomi Valkeinen
2016-02-22 17:10 ` [PATCH 42/42] drm/omap: remove dispc_ovl_check() Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DD3AC1.7070909@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).