From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 40/42] drm/omap: remove last uses of omap_overlay_manager Date: Mon, 7 Mar 2016 11:10:52 +0200 Message-ID: <56DD459C.8070907@ti.com> References: <1456161048-21240-1-git-send-email-tomi.valkeinen@ti.com> <1456161048-21240-41-git-send-email-tomi.valkeinen@ti.com> <1796987.1jVFH4SYUv@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0395912776==" Return-path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7EFD66E30F for ; Mon, 7 Mar 2016 09:10:58 +0000 (UTC) In-Reply-To: <1796987.1jVFH4SYUv@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0395912776== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5Vd0LGLn2bVcAOxjA4jujEugTOxHnwDPF" --5Vd0LGLn2bVcAOxjA4jujEugTOxHnwDPF Content-Type: multipart/mixed; boundary="mVsEC6ihpWu5Uxb8dS0vWVJmDELGBcPDJ" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Rob Clark Message-ID: <56DD459C.8070907@ti.com> Subject: Re: [PATCH 40/42] drm/omap: remove last uses of omap_overlay_manager References: <1456161048-21240-1-git-send-email-tomi.valkeinen@ti.com> <1456161048-21240-41-git-send-email-tomi.valkeinen@ti.com> <1796987.1jVFH4SYUv@avalon> In-Reply-To: <1796987.1jVFH4SYUv@avalon> --mVsEC6ihpWu5Uxb8dS0vWVJmDELGBcPDJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/03/16 11:01, Laurent Pinchart wrote: > Hi Tomi, >=20 > Thank you for the patch. >=20 > On Monday 22 February 2016 19:10:46 Tomi Valkeinen wrote: >> We have now removed all uses of 'struct omap_overlay_manager', so we c= an >> now remove the last places where it is set. >=20 > Shouldn't you also move the definition of the structure to a header pri= vate to=20 > omapfb, as it's not used by omapdrm anymore ? Yes if it was private to omapfb. Unfortunately omap_vout uses omapdss, and thus omap_overlay_manager. So more cleanup is needed... Tomi --mVsEC6ihpWu5Uxb8dS0vWVJmDELGBcPDJ-- --5Vd0LGLn2bVcAOxjA4jujEugTOxHnwDPF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW3UWcAAoJEPo9qoy8lh715CIP/3Oydxy7VFdTFNbyS4gNlXhr hNLlSL5BcL3TRa9D5Yg0uWgOrg3c7XXNLuMMFuZr2Eml2rxCwk5OzvRYSFeHtgJ6 VYqIDhUam/s2ji1iRDYAzaUIJEqcqLGFg9teP3NIVKSIISo+o4pUx8n/xWoyBqus 0k7Gif9dUVx+E++CXtLbTupnfXPC9hw+Uvg+ET2jKUmMpspsOR1TEZX317P4LbkN oQtC6no7+/VV7tnLAaYlt72elSJrDPuSI4mzgPflmp2LzvMrSwSYNAdqd7tsrkgk e+BCUgCYBP7J07GOyH3LO1yxjdSojwgOxkD74eZmEX+hewAPknYGdYJibHbH18Rv USspeQmS4GJwY60ZK1D1yj1BE7ISnH3otNbJoNydCdKmz5rN1J4A90E3DfOFcsr6 XicDcRO6FQUaQAMzpcFGSNl45ki9Z72v3qwPHmeaPib7xc8Wf3gKMfMmgN8eFZo1 Hnn5xI75BqxwdwZ9KmEzh2xiE/Tps5aAStF4YXA0cR0UBuA5Ge9RyGsn4Zv7Scpq 1ACU+gyvclLD5p8uXHxa6YNsj/LNX+VdyJFpXcxriCh1HPRophgPiZJwLpyM8HIJ +orDUwddc89PaDLz7W9IW39jI38agoP10DiUqoFKvaHvITrR3YaaaL50Hab1WRM7 VFo93g14XZKvVdJXXYY3 =8ijI -----END PGP SIGNATURE----- --5Vd0LGLn2bVcAOxjA4jujEugTOxHnwDPF-- --===============0395912776== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0395912776==--