From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH 8/8] drm: atmel-hlcdc: check display mode validity in crtc->mode_fixup() Date: Tue, 8 Mar 2016 16:44:23 +0100 Message-ID: <56DEF357.5050003@atmel.com> References: <1452075569-8545-1-git-send-email-boris.brezillon@free-electrons.com> <1452075569-8545-9-git-send-email-boris.brezillon@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1452075569-8545-9-git-send-email-boris.brezillon@free-electrons.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Boris Brezillon , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Cc: Alexandre Belloni , Jean-Christophe Plagniol-Villard , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org Le 06/01/2016 11:19, Boris Brezillon a =E9crit : > Move the adjusted display mode check into ->mode_fixup(). > = > Signed-off-by: Boris Brezillon Seems okay: Acked-by: Nicolas Ferre > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > = > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu= /drm/atmel-hlcdc/atmel_hlcdc_crtc.c > index be30bd2..d5a028f 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > @@ -142,11 +142,13 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct d= rm_crtc *c) > cfg); > } > = > -static bool atmel_hlcdc_crtc_mode_fixup(struct drm_crtc *crtc, > +static bool atmel_hlcdc_crtc_mode_fixup(struct drm_crtc *c, > const struct drm_display_mode *mode, > struct drm_display_mode *adjusted_mode) > { > - return true; > + struct atmel_hlcdc_crtc *crtc =3D drm_crtc_to_atmel_hlcdc_crtc(c); > + > + return atmel_hlcdc_dc_mode_valid(crtc->dc, adjusted_mode) =3D=3D MODE_O= K; > } > = > static void atmel_hlcdc_crtc_disable(struct drm_crtc *c) > @@ -311,12 +313,8 @@ static int atmel_hlcdc_crtc_select_output_mode(struc= t drm_crtc_state *state) > static int atmel_hlcdc_crtc_atomic_check(struct drm_crtc *c, > struct drm_crtc_state *s) > { > - struct atmel_hlcdc_crtc *crtc =3D drm_crtc_to_atmel_hlcdc_crtc(c); > int ret; > = > - if (atmel_hlcdc_dc_mode_valid(crtc->dc, &s->adjusted_mode) !=3D MODE_OK) > - return -EINVAL; > - > ret =3D atmel_hlcdc_crtc_select_output_mode(s); > if (ret) > return ret; > = -- = Nicolas Ferre