dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: omap4: how to get the HDMI core IRQ?
Date: Wed, 30 Mar 2016 13:37:45 +0300	[thread overview]
Message-ID: <56FBAC79.6060405@ti.com> (raw)
In-Reply-To: <56F45A30.4070701@xs4all.nl>


[-- Attachment #1.1.1: Type: text/plain, Size: 1670 bytes --]

Hi Hans,

On 24/03/16 23:20, Hans Verkuil wrote:
> Hi Tomi,
> 
> I hope you (or someone else on this list) can help me find the problem in this code.
> 
> I am working on a kernel framework for HDMI CEC (see https://lwn.net/Articles/680942/).
> In order to get as much experience with different devices as possible I am trying to
> implement it on my omap4430 Pandaboard. The big problem I am facing is that the CEC
> interrupts come in through the HDMI_IRQ_CORE interrupt, and that just refuses to
> trigger.
> 
> The code below adds support for this core interrupt and it is supposed to trigger it
> using the Software Induced interrupt to keep the code as simple as possible.

So this irq is just for testing?

> On boot I get this debug line from the pr_info in my code:
> 
> irqstat 02000000 wp_irq 06000001 raw 20010000 intr_state 00000001 intr1 00000080 unmask1 00000080 intr_ctrl 0000000a
> 
> As far as I can see everything looks perfectly fine, except for the fact that bit 0
> of the irqstat is stubbornly 0.
> 
> This is using kernel 4.5 with only this patch applied.
> 
> What am I missing?

Set SYS_CTRL1:PD to 1 (I presume you have the NDA HDMI TRM?).

Apparently we set it always to 0 in
hdmi4_core.c:hdmi_core_powerdown_disable(), but never enable it. I guess
it only affects core irqs, so there have been no side effects.

But it would make sense to either have a matching call in the enable
path, or then just set it to 0 when initializing the IP.

> 
> The reward for the right answer will be HDMI CEC support for omap4 (and any other TI device
> with the same CEC IP).

Ok. When is it ready? ;)

 Tomi


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-03-30 10:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-24 21:20 omap4: how to get the HDMI core IRQ? Hans Verkuil
2016-03-30 10:37 ` Tomi Valkeinen [this message]
2016-04-01  0:46   ` Hans Verkuil
2016-04-01  7:03     ` Tomi Valkeinen
2016-04-01  7:35       ` Tomi Valkeinen
2016-04-01 16:56         ` Hans Verkuil
2016-04-01 16:59           ` Tomi Valkeinen
2016-04-10 12:02         ` Hans Verkuil
2016-04-01 16:51       ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56FBAC79.6060405@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hverkuil@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox