From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
ville.syrjala@linux.intel.com, dri-devel@lists.freedesktop.org,
daniel@ffwll.ch
Cc: linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH 0/2] drm: add generic zpos property
Date: Fri, 01 Apr 2016 14:13:40 +0200 [thread overview]
Message-ID: <56FE65F4.6090009@samsung.com> (raw)
In-Reply-To: <1459337672-22672-1-git-send-email-benjamin.gaignard@linaro.org>
Hello,
On 2016-03-30 13:34, Benjamin Gaignard wrote:
> The original patches have been done by Marek:
> https://lists.freedesktop.org/archives/dri-devel/2016-January/099572.html
>
> I have just adapt them to make zpos depend on plane and no more on drm core.
>
> Since zpos range can be define per plane normalize function takes care of
> the min and max before compute normalized zpos value.
Thanks for handling this. I was terribly busy with internal stuff and had no
time to check all my emails. Usually if one continues someone else patches,
it is a good practice to somehow credit the original author in the final
patch.
If changes are small, I usually keep the original authorship and only add
note before my signoff (see commit 855ed04a3758b205e84b269f92d26ab36ed8e2f7
for the example). When the whole code has been rewritten, modified or
heavily
extended, I changed authorship and added respective note to the commit
message
(see commit e8d9d1f5485b52ec3c4d7af839e6914438f6c285 for such example). Feel
free to use any of those styles.
> Benjamin Gaignard (2):
> drm: add generic zpos property
> drm: sti: use generic zpos for plane
>
> Documentation/DocBook/gpu.tmpl | 10 ++
> drivers/gpu/drm/Makefile | 2 +-
> drivers/gpu/drm/drm_atomic.c | 4 +
> drivers/gpu/drm/drm_atomic_helper.c | 6 +
> drivers/gpu/drm/drm_blend.c | 242 ++++++++++++++++++++++++++++++++++++
> drivers/gpu/drm/drm_crtc_internal.h | 3 +
> drivers/gpu/drm/sti/sti_mixer.c | 2 +-
> drivers/gpu/drm/sti/sti_plane.c | 82 +++++-------
> drivers/gpu/drm/sti/sti_plane.h | 2 -
> include/drm/drm_crtc.h | 17 +++
> 10 files changed, 314 insertions(+), 56 deletions(-)
> create mode 100644 drivers/gpu/drm/drm_blend.c
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-04-01 12:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 11:34 [PATCH 0/2] drm: add generic zpos property Benjamin Gaignard
2016-03-30 11:34 ` [PATCH 1/2] " Benjamin Gaignard
2016-03-30 11:34 ` [PATCH 2/2] drm: sti: use generic zpos for plane Benjamin Gaignard
2016-03-30 12:38 ` [PATCH 0/2] drm: add generic zpos property Thierry Reding
2016-04-01 12:13 ` Marek Szyprowski [this message]
2016-04-01 13:35 ` Emil Velikov
2016-04-01 13:37 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FE65F4.6090009@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=benjamin.gaignard@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox