From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: ville.syrjala@linux.intel.com, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Replace nondescript 'WARN_ON(!lret)' with a sensible error message
Date: Mon, 18 Apr 2016 13:43:13 +0200 [thread overview]
Message-ID: <5714C851.4040703@linux.intel.com> (raw)
In-Reply-To: <1460978973-24945-1-git-send-email-ville.syrjala@linux.intel.com>
Op 18-04-16 om 13:29 schreef ville.syrjala@linux.intel.com:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> When a vblank wait times out in intel_atomic_wait_for_vblanks() we just
> get a cryptic 'WARN_ON(!ret)' backtrace in dmesg. Repace it with
> something that tells you what actually happened.
>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 4cca155376be..7bdbe4b03591 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13523,7 +13523,7 @@ static void intel_atomic_wait_for_vblanks(struct drm_device *dev,
> drm_crtc_vblank_count(crtc),
> msecs_to_jiffies(50));
>
> - WARN_ON(!lret);
> + WARN(!lret, "pipe %c vblank wait timed out\n", pipe_name(pipe));
>
> drm_crtc_vblank_put(crtc);
> }
This helper function was never meant to last as long as it did. :(
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-18 11:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 11:29 [PATCH 1/2] drm/i915: Replace nondescript 'WARN_ON(!lret)' with a sensible error message ville.syrjala
2016-04-18 11:29 ` [PATCH 2/2] drm/atomic-helper: Print an error if vblank wait times out ville.syrjala
2016-04-18 12:31 ` Daniel Vetter
2016-04-18 11:43 ` Maarten Lankhorst [this message]
2016-04-18 15:56 ` [PATCH 1/2] drm/i915: Replace nondescript 'WARN_ON(!lret)' with a sensible error message Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5714C851.4040703@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox